Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

"Find uses Selected Text" broken

<< < (3/5) > >>

Biplab:

--- Quote from: Pecan on May 28, 2007, 06:46:44 pm ---I'll have to respecfully disagree again. Reverting the fix does indeed create bug 10992 on my (msw) system.

I'm not sure it's a bug though.

--- End quote ---

I'm also not sure that this is a bug. I reverted it as it works other way. ;)

But we need a solution if it's really a bug.

dmoore:
my planned fix for this bug (10992) was to change the default scope to global if a newline was not included in the selection (i.e. if the selection is less than an entire line then default to global scope).

dmoore:
hi guys:

patch here: http://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=2027&group_id=5358

note that I have removed the disabling of the scope as the user might want to change to the selected scope to find a substring in a very long line of text

cheers
Damien

Pecan:
I've applied the patch locally. And have been using it all morning.

It defininitely does the job for both "FindUsesSelectedText" and NON "FindUsesSelectedText".

It seems to please both worlds.


I vote to get biplab to apply it to SVN for further heavy testing.

dmoore:
I've just updated the patch (forgot to remove scope disabling in the replace dialog)

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version