Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Suggestions before next release

(1/2) > >>

Ceniza:
I would like to see two things related to Search -> Find done before the next release:

1. Find enabled for Single File: it's a bit frustrating to open a single file and be unable to search for something.
2. When the Find dialog is opened, give focus to the ComboBox (the focus is in the tab by default). Same for Find in files.

It would also be good to have the Message pane really auto-hiding when you start typing (of course, if it's checked).

Another nice feature would be having the most recently opened projects listed in the "Start here" page so you can quickly open them. This feature could be implemented after the next release though.

Ceniza:
Well, instead of just asking for it I'll give you the code:

src/main.cpp line 1861 from:

--- Code: ---mbar->Enable(idSearchFind, prj);
--- End code ---
to:

--- Code: ---mbar->Enable(idSearchFind, prj || ed);
--- End code ---

sdk/finddlg.cpp line 83 from:

--- Code: ---if (!m_Complete)
  XRCCTRL(*this, "nbFind", wxNotebook)->DeletePage(0); // no active editor, so only find-in-files
--- End code ---
to:

--- Code: ---m_FindInFilesTab = true;
if (!m_Complete)
{
  XRCCTRL(*this, "nbFind", wxNotebook)->DeletePage(0); // no active editor, so only find-in-files
  XRCCTRL(*this, "cmbFind2", wxComboBox)->SetFocus(); // give focus to the ComboBox
}
else
{
  if (!Manager::Get()->GetProjectManager())
  {
    XRCCTRL(*this, "nbFind", wxNotebook)->DeletePage(1); // no project, so only find
    m_FindInFilesTab = false;
  }
 
  XRCCTRL(*this, "cmbFind1", wxComboBox)->SetFocus(); // give focus to the ComboBox
}
--- End code ---

sdk/finddlg.cpp FindDlg::~FindDlg() last lines (sorry, I lost track of the line) from:

--- Code: ---// find in files options
--- End code ---
to:

--- Code: ---if (!m_FindInFilesTab)
{
  return;
}

// find in files options
--- End code ---

sdk/finddlg.cpp void FindDlg::OnFindChange last lines (lost track too) from:

--- Code: ---else if (cmbFind1)
--- End code ---
to:

--- Code: ---else if (cmbFind1 && cmbFind2)
--- End code ---

sdk/finddlg.cpp somewhere in the first lines add:

--- Code: ---#include "manager.h"
#include "projectmanager.h"
--- End code ---

sdk/finddlg.h line 25 from:

--- Code: ---bool m_Complete;
--- End code ---
to:

--- Code: ---bool m_Complete;
bool m_FindInFilesTab;
--- End code ---

Sorry for all this mess but for what I saw the Find Dialog wasn't ready for single file. It should be changed because the old m_Complete wouldn't make sense now (since !m_Complete can mean either Find or Find In Files tab only), reason I added m_FindInFilesTab.

Well, I think that's all, but maybe I forgot to put some more changes here to get it working. It required more editing than I thought.

Oh, and I hope the "Start here" page change be considered too.

Note: this post was heavily edited.

mandrav:
Unfortunately, it can't make it for the RC1. It should be out yesterday but some personal problems kept me from releasing it, which I will do today. It wouldn't be wise to add these last-minute without enough testing (other than yours)...

It will be added in CVS after RC1 is released.

Thanks,
Yiannis.

rickg22:
I have also some changes pending for 1.0. Like adding a filename filter or target limiting to find in files.

I think we'll incorporate these in RC2.

darklordsatan:

--- Quote from: rickg22 on July 25, 2005, 02:35:30 pm ---I think we'll incorporate these in RC2.

--- End quote ---

? I thought there would only be one RC before 1.0 stable, how many RCs do you think then?

Navigation

[0] Message Index

[#] Next page