wxWidgets 2.6.4 Screws Up File-Type Icons!

Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

<< < (4/4)

mandrav:

--- Quote from: Biplab on March 26, 2007, 12:20:32 pm ---Following patch should fix this issue.

--- Code: ------ C:/wxWidgets-2.6.4/include/wx/msw/wx.rc Mon Mar 26 18:15:59 2007
+++ C:/wxWidgets-2.6.4/include/wx/msw/wx.rc Mon Mar 26 18:17:13 2007
@@ -79,7 +79,7 @@

// Low alphabetically to make it the default, but not so low as to
// affect applications that use 'a'
-bICON ICON "wx/msw/std.ico"
+//bICON ICON "wx/msw/std.ico"

//////////////////////////////////////////////////////////////////////////////
//
--- End code ---

Though I've not tested the patch, but I'm quite sure that this is the source of problem.

I'll post the result after another full recompilation with wxWidgets-2.6.4.

Regards,

Biplab

--- End quote ---

I know this should fix it, but it will have side-effects...
By not importing the wx resources, we "lose" some necessary icons (like the right-pointing arrow displayed when hovering over the editor's left margin).
The "proper" way (if such thing exists) would be to alter our indices in associations.cpp based on the wxwidgets version. I think...

Biplab:

--- Quote from: mandrav on March 26, 2007, 01:51:27 pm ---I know this should fix it, but it will have side-effects...
By not importing the wx resources, we "lose" some necessary icons (like the right-pointing arrow displayed when hovering over the editor's left margin).
The "proper" way (if such thing exists) would be to alter our indices in associations.cpp based on the wxwidgets version. I think...

--- End quote ---

No, this would not have any side effects. :)

If you look at the CVS of wxWidgets, that line was introduced in one revision and later was deleted and replaced with older code.

I'm posting the diff between latest wx.rc and the file supplied with wx-2.6.4.

--- Code: ------ C:/wxWidgets-2.6.4/include/wx/msw/wx.rc Mon Mar 26 20:04:24 2007
+++ C:/wxMSW-2.9.0/include/wx/msw/wx.rc Sun Feb 11 12:54:58 2007
@@ -6,7 +6,7 @@
// Modified by:
// Created:
// Copyright: (c) Julian Smart
-// RCS-ID: $Id: wx.rc,v 1.43.2.3 2006/06/18 11:06:36 JS Exp $
+// RCS-ID: $Id: wx.rc,v 1.49 2006/11/18 16:46:59 VZ Exp $
// Licence: wxWindows Licence
/////////////////////////////////////////////////////////////////////////////

@@ -63,6 +63,10 @@
// Default Icons
//

+// First wx icon in alphabetical order, so it will be used by Explorer if the
+// application doesn't have any icons of its own
+wxICON_AAA ICON "wx/msw/std.ico"
+
//wxDEFAULT_FRAME ICON "wx/msw/std.ico"
//wxDEFAULT_MDIPARENTFRAME ICON "wx/msw/mdi.ico"
//wxDEFAULT_MDICHILDFRAME ICON "wx/msw/child.ico"
@@ -77,10 +81,6 @@
wxICON_SMALL_FLOPPY ICON "wx/msw/floppy.ico"
wxICON_SMALL_REMOVEABLE ICON "wx/msw/removble.ico"

-// Low alphabetically to make it the default, but not so low as to
-// affect applications that use 'a'
-bICON ICON "wx/msw/std.ico"
-
//////////////////////////////////////////////////////////////////////////////
//
// Bitmaps
@@ -100,12 +100,19 @@
#if !defined(wxUSE_NO_MANIFEST) || (wxUSE_NO_MANIFEST == 0)
#if !defined(WX_MSC_FULL_VER) || WX_MSC_FULL_VER < 140040130

+// see "about isolated applications" topic in MSDN
+#ifdef ISOLATION_AWARE_ENABLED
+#define wxMANIFEST_ID 2
+#else
+#define wxMANIFEST_ID 1
+#endif
+
#if defined(WX_CPU_AMD64)
-1 24 "wx/msw/amd64.manifest"
+wxMANIFEST_ID 24 "wx/msw/amd64.manifest"
#elif defined(WX_CPU_IA64)
-1 24 "wx/msw/ia64.manifest"
+wxMANIFEST_ID 24 "wx/msw/ia64.manifest"
#elif defined(WX_CPU_X86)
-1 24 "wx/msw/wx.manifest"
+wxMANIFEST_ID 24 "wx/msw/wx.manifest"
#endif

#endif // !defined(WX_MSC_FULL_VER) || WX_MSC_FULL_VER < 140040130
--- End code ---

I'm using it currently. If I see any missing icons, cursors, I'll post.

Regards,

Biplab

killerbot:
any new side effects seen ?

Might make a mightly with wx2.6.4, but once more a patched one because of this issue .
Jolly nice wx ......

Biplab:

--- Quote from: killerbot on March 27, 2007, 09:39:22 am ---any new side effects seen ?

--- End quote ---

No, Not yet.

IMHO, it should not create any side-effects. Only the standard wx icon inclusion is removed. Rest of the wx resources will be added. :)

They've already replaced that line in newer version of wx. But unfortunately, wx-2.6.4 got the buggy one. :(

--- Quote from: killerbot on March 27, 2007, 09:39:22 am ---Might make a mightly with wx2.6.4, but once more a patched one because of this issue .
Jolly nice wx ......

--- End quote ---

No, not necessary. The runtime dll will not be affected. Only during compilation of any exe file based on wx-2.6.4 (in this case codeblocks.exe), that patch is necessary. :)

Regards,

Biplab

Navigation

[0] Message Index

[*] Previous page

Go to full version