Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development
wxSmith and patch 1903 for wxW28 and wxPropertyGrid 1.2.x
stahta01:
Byo:
Do you plan on applying my patch?
[ Patch #1903 ] wxSmith patch for wxW28 and wxPropertyGrid 1.2.x
https://developer.berlios.de/patch/?func=detailpatch&patch_id=1903&group_id=5358
Do you want me to split the patch into smaller patches?
If split, how do you want me to split the patch? wx28 and wxPropertyGrid 1.2.x?
Tim S
stahta01:
Found that only one file in wxSmith is left to be patched in order to use wxPropertyGrid 1.2.x; this is NOT counting build files patched by Berlios Patch 1912 "Patch CB Build Files to use wxPropertyGrid 1.2.6"
https://developer.berlios.de/patch/?func=detailpatch&patch_id=1912&group_id=5358
(WXMAKINGLIB_PROPGRID-unix.patch)
Tim S
--- Code: ---Index: src/plugins/contrib/wxSmith/wxwidgets/properties/wxscolourproperty.cpp
===================================================================
--- src/plugins/contrib/wxSmith/wxwidgets/properties/wxscolourproperty.cpp (revision 3692)
+++ src/plugins/contrib/wxSmith/wxwidgets/properties/wxscolourproperty.cpp (working copy)
@@ -128,7 +128,11 @@
wxSYS_COLOUR_MENUBAR
};
+#if defined(wxPG_VERSION) && wxPG_VERSION > 1099
+ WX_PG_IMPLEMENT_PROPERTY_CLASS(wxsMyColourProperty,wxEnumProperty,wxColourPropertyValue,const wxColourPropertyValue&,Choice)
+#else
WX_PG_IMPLEMENT_PROPERTY_CLASS(wxsMyColourProperty,wxColourPropertyValue,const wxColourPropertyValue&,Choice)
+#endif
wxsMyColourPropertyClass::wxsMyColourPropertyClass( const wxString& label, const wxString& name,
const wxColourPropertyValue& value )
@@ -181,7 +185,11 @@
(int)m_value.m_colour.Red(),(int)m_value.m_colour.Green(),(int)m_value.m_colour.Blue());
return temp;
}
+#if defined(wxPG_VERSION) && wxPG_VERSION > 1099
+ return m_choices.GetLabel(m_index);
+#else
return m_constants->GetLabel(m_index);
+#endif
}
wxSize wxsMyColourPropertyClass::GetImageSize() const
--- End code ---
byo:
--- Quote from: stahta01 on March 22, 2007, 01:05:53 am ---Byo:
Do you plan on applying my patch?
[ Patch #1903 ] wxSmith patch for wxW28 and wxPropertyGrid 1.2.x
https://developer.berlios.de/patch/?func=detailpatch&patch_id=1903&group_id=5358
Do you want me to split the patch into smaller patches?
If split, how do you want me to split the patch? wx28 and wxPropertyGrid 1.2.x?
Tim S
--- End quote ---
Yup, I'd like to switch into newer wxPropertyGrid, probably do it this evening :) Have you tested if wxSmith works fine with new wxPG ?
BYO
byo:
I've got one question: In patch for compatibility with wx2.8 you've commented some styles inside wxSmith like:
--- Code: --- // WXS_ST(wxNO_3D)
--- End code ---
What was the purpose ? Does it make problem to compile using wx 2.8 ? Coz even if style is not yet supported but the older version remains, it can still be used inside XRC files with old name so excluding such styles may lead to incompatibility problems.
BYO
stahta01:
--- Quote from: byo on March 23, 2007, 08:49:12 pm ---I've got one question: In patch for compatibility with wx2.8 you've commented some styles inside wxSmith like:
--- Code: --- // WXS_ST(wxNO_3D)
--- End code ---
What was the purpose ? Does it make problem to compile using wx 2.8 ? Coz even if style is not yet supported but the older version remains, it can still be used inside XRC files with old name so excluding such styles may lead to incompatibility problems.
BYO
--- End quote ---
It has a problem with 2.8 with 2.6 compatible mode turned off, wxNO_3D does nothing under 2.6.
from wx/toplevel.h
--- Code: ---// deprecated versions defined for compatibility reasons
#define wxRESIZE_BOX wxMAXIMIZE_BOX
#define wxTHICK_FRAME wxRESIZE_BORDER
// obsolete styles, unused any more
#define wxDIALOG_MODAL 0
#define wxDIALOG_MODELESS 0
#define wxNO_3D 0
#define wxUSER_COLOURS 0
--- End code ---
Navigation
[0] Message Index
[#] Next page
Go to full version