Author Topic: Registry checks?  (Read 5356 times)

Offline rickg22

  • Lives here!
  • ****
  • Posts: 2283
Registry checks?
« on: July 11, 2005, 06:08:33 pm »
I'm posting this because of the "sidebar gone" bug and also the TODO which hasn't been fixed yet - and I don't know how to fix it either :oops:

Anyway, It seems that we don't have restrain checks for registry-stored variables. For example, the "sidebar gone" screwed up when (accidentally?) the value for a certain config dropped below zero. Shouldn't we do a check for min and max values of certain variables before loading them?

This reminds me of my PHP programming times: *NEVER* trust user input. And well, in this case it should be: "Don't trust the registry, it breaks too often :lol: ".

So, what do you think?

Offline David Perfors

  • Developer
  • Lives here!
  • *****
  • Posts: 560
Registry checks?
« Reply #1 on: July 11, 2005, 08:34:31 pm »
min values should always be checked... indeed never trust ANY input :P
OS: winXP
Compiler: mingw
IDE: Code::Blocks SVN WX: 2.8.4 Wish list: faster code completion, easier debugging, refactoring