Author Topic: Refixed: pull-down-menus-images-not-changing-state Issue  (Read 18281 times)

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5491
Re: FIXED: toolbar-images-not-changing-state Issue
« Reply #15 on: January 12, 2007, 11:15:51 am »
on linux they look good, under the gray out you can even see the original colors (so with a gray shade on top of them), also in linux when you mouse over, those menu entries don;t get a blue overlay when the mouse is over them, on windows you have this blue overlay (no idea which one of the 2 is the desired behavior), AND when you mouse over those entries (the grayed outs) the first letter of every entry is prepended --> Start becomes SStart

Offline stahta01

  • Lives here!
  • ****
  • Posts: 7588
    • My Best Post
Re: FIXED: toolbar-images-not-changing-state Issue
« Reply #16 on: January 12, 2007, 11:22:48 am »
on linux they look good, under the gray out you can even see the original colors (so with a gray shade on top of them), also in linux when you mouse over, those menu entries don;t get a blue overlay when the mouse is over them, on windows you have this blue overlay (no idea which one of the 2 is the desired behavior), AND when you mouse over those entries (the grayed outs) the first letter of every entry is prepended --> Start becomes SStart

I am NOT seeing the first letter being pre-pended. Could be a window setting or code::block setting difference.

Why don't you look at the other patch fixing the find/search icon and hold off on this one while I try for better looking results.
Tim S
C Programmer working to learn more about C++ and Git.
On Windows 7 64 bit and Windows 10 64 bit.
--
When in doubt, read the CB WiKi FAQ. http://wiki.codeblocks.org

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5491
Re: FIXED: toolbar-images-not-changing-state Issue
« Reply #17 on: January 12, 2007, 02:07:56 pm »
You are talking about the 22*22 png, correct ? I will apply that one ;-)

Offline stahta01

  • Lives here!
  • ****
  • Posts: 7588
    • My Best Post
Re: FIXED: toolbar-images-not-changing-state Issue
« Reply #18 on: January 12, 2007, 02:50:33 pm »
You are talking about the 22*22 png, correct ? I will apply that one ;-)

No it fixes the 16*16 code issue.
http://forums.codeblocks.org/index.php?topic=4926.0

I did create a 22*22 png that you could put in SVN.
http://forums.codeblocks.org/index.php?topic=4912.msg38407#msg38407
« Last Edit: January 12, 2007, 02:53:13 pm by stahta01 »
C Programmer working to learn more about C++ and Git.
On Windows 7 64 bit and Windows 10 64 bit.
--
When in doubt, read the CB WiKi FAQ. http://wiki.codeblocks.org

Offline stahta01

  • Lives here!
  • ****
  • Posts: 7588
    • My Best Post
Re: FIXED: toolbar-images-not-changing-state Issue
« Reply #19 on: January 13, 2007, 12:05:13 am »
on linux they look good, under the gray out you can even see the original colors (so with a gray shade on top of them), also in linux when you mouse over, those menu entries don;t get a blue overlay when the mouse is over them, on windows you have this blue overlay (no idea which one of the 2 is the desired behavior), AND when you mouse over those entries (the grayed outs) the first letter of every entry is prepended --> Start becomes SStart

I found the cause of SStart problem, my prior patch and this one caused it when both are applied.
I am fixing my alignment of menuitems patch right now.
I also rewrote the gray bitmap routine so it looks much better.
I have to test them both again at the same time to verify I fixed the "SStart" problem.
[note the short-cut key was also prepending right before the bitmaps sometimes.]
Tim S
C Programmer working to learn more about C++ and Git.
On Windows 7 64 bit and Windows 10 64 bit.
--
When in doubt, read the CB WiKi FAQ. http://wiki.codeblocks.org

Offline stahta01

  • Lives here!
  • ****
  • Posts: 7588
    • My Best Post
Re: RE-WORK: toolbar-images-not-changing-state Issue
« Reply #20 on: January 17, 2007, 04:08:27 pm »
I am testing my back port of the wxWidgets 2.8.1+ code to fix the issue on the 2.6 branch, note it is very modified from the 2.8 code.
Tim S
C Programmer working to learn more about C++ and Git.
On Windows 7 64 bit and Windows 10 64 bit.
--
When in doubt, read the CB WiKi FAQ. http://wiki.codeblocks.org

Offline stahta01

  • Lives here!
  • ****
  • Posts: 7588
    • My Best Post
Re: RE-WORK: toolbar-images-not-changing-state Issue
« Reply #21 on: January 17, 2007, 04:47:59 pm »
I have highly modified how the fix to this problem was fixed in CVS head. Use patch 1637804 to fix this issue.
Tim S

[ 1637804 ] MSW: ownerdrw.cpp backport to 2.6_BRANCH from cvs head
http://sourceforge.net/tracker/index.php?func=detail&aid=1637804&group_id=9863&atid=309863

C Programmer working to learn more about C++ and Git.
On Windows 7 64 bit and Windows 10 64 bit.
--
When in doubt, read the CB WiKi FAQ. http://wiki.codeblocks.org