User forums > Nightly builds
The 03 january 2007 build is out.
artoj:
--- Quote from: mandrav on January 03, 2007, 11:15:11 pm ---arto, you really should use CDATA for the snippets. The reason is simple: one special character in the snippet and the whole snippets xml file will become unreadable.
--- End quote ---
I'm not exactly following you, which special characters will break the XML file when used from the GUI? I can use !"#¤%&/()=?`´@£$^¨åäö*'~<> without any problems. :?:
mandrav:
--- Quote from: artoj on January 04, 2007, 12:04:55 pm ---
--- Quote from: mandrav on January 03, 2007, 11:15:11 pm ---arto, you really should use CDATA for the snippets. The reason is simple: one special character in the snippet and the whole snippets xml file will become unreadable.
--- End quote ---
I'm not exactly following you, which special characters will break the XML file when used from the GUI? I can use !"#¤%&/()=?`´@£$^¨åäö*'~<> without any problems. :?:
--- End quote ---
I admit I haven't looked at your code and you might very well handle the special characters yourself. But this wouldn't be needed if you just used CDATA. All formatting would be preserved and you wouldn't have to worry about special chars.
And yes, I 'm talking about <> and others...
Anyway, this was just a suggestion.
artoj:
--- Quote from: mandrav on January 04, 2007, 01:10:13 pm ---I admit I haven't looked at your code and you might very well handle the special characters yourself. But this wouldn't be needed if you just used CDATA. All formatting would be preserved and you wouldn't have to worry about special chars.
--- End quote ---
TinyXML escapes the special characters I mentioned automatically. The whitespace was the only problem with formatting and it's now (soon) fixed. Tabs for example were handled correctly before.
EDIT: However, I've taken your warning about data loss seriously and the codesnippets.xml is now backupped if it's not valid XML. While in normal case creating an invalid XML should never happen (TinyXML does all the XML job), manually editing the file might led to it.
thomas:
Arto, you may really want to listen to Yiannis :) Seriously, we've tried it all before with the config file.
I kept telling the Chinese guys over and over again: "But it works! It must! TinyXML escapes illegal chars". However, it turned out that after we used CDATA, it would mysteriously work for everybody when it would not before. Nobody has ever been complaining again.
The "bugfix" - if you want to call it that - is one additional line of code, so it's really not a big pain.
artoj:
--- Quote from: thomas on January 04, 2007, 02:53:16 pm ---However, it turned out that after we used CDATA, it would mysteriously work for everybody when it would not before. Nobody has ever been complaining again.
--- End quote ---
Not good enough, if there's really a bug, it needs to be fixed.
Did you notify the TinyXML developers about the issue?
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version