Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Refixed wxWidget Patch: menu items with icon not correctly aligned (since wx263)
stahta01:
--- Quote from: killerbot on December 29, 2006, 09:26:20 pm ---you are talking about the line in "wxMenu::DoInsertOrAppend", correct ?
this was how it was in wx262
--- Code: --- // is the item owner-drawn just because of the bitmap?
if ( pItem->GetBitmap().Ok() &&
!pItem->GetTextColour().Ok() &&
!pItem->GetBackgroundColour().Ok() &&
!pItem->GetFont().Ok() )
{
// try to use InsertMenuItem() as it's guaranteed to look correctly
// while our owner-drawning code is not
--- End code ---
and in wx 263 they changed it into :
--- Code: --- // is the item owner-drawn just because of the bitmap?
if ( pItem->GetBitmap().Ok() &&
!pItem->GetTextColour().Ok() &&
!pItem->GetBackgroundColour().Ok() &&
!pItem->GetFont().Ok() &&
!pItem->GetBitmap(true).Ok() )
{
// try to use InsertMenuItem() as it's guaranteed to look correctly
// while our owner-drawning code is not
--- End code ---
did you bring this to the attention of the wx guys.
I am gonna rebuild our wx_cb_dll, this is a nice fix (hopefully with no side effects).
--- End quote ---
Correct that were I fixed it, and it worked with CVS 2.6_BRANCH with that change. I just commented out to test it like below.
if ( pItem->GetBitmap().Ok() &&
!pItem->GetTextColour().Ok() &&
!pItem->GetBackgroundColour().Ok() &&
!pItem->GetFont().Ok() /* &&
!pItem->GetBitmap(true).Ok() */ )
killerbot:
well there's good new and bad news :
1) good news : menu entries are nicely aligned again
2) BAD news : 90% of the icons in the menus are gone (example : build : only abort has an icon, debug : only stop debugger has an icon) [I kind of recall we have had this in the past]
Or could there be a problem with our icons ??
Tim, since you are on those wx mailing list, could you provide them with this information, maybe it will help them understand ?
stahta01:
--- Quote from: killerbot on December 29, 2006, 09:49:55 pm ---well there's good new and bad news :
1) good news : menu entries are nicely aligned again
2) BAD news : 90% of the icons in the menus are gone (example : build : only abort has an icon, debug : only stop debugger has an icon) [I kind of recall we have had this in the past]
Or could there be a problem with our icons ??
Tim, since you are on those wx mailing list, could you provide them with this information, maybe it will help them understand ?
--- End quote ---
I don't see the 2) BAD News, when I did it. (Using CVS not 2.6.3p2)
I will check with the 2.6.3p2 version of code and see if I see the bad news.
Tim S
Pecan:
--- Quote from: killerbot on December 29, 2006, 09:49:55 pm ---well there's good new and bad news :
1) good news : menu entries are nicely aligned again
2) BAD news : 90% of the icons in the menus are gone (example : build : only abort has an icon, debug : only stop debugger has an icon) [I kind of recall we have had this in the past]
Or could there be a problem with our icons ??
--- End quote ---
2) was caused by keyBinder in the past. About a year ago (wx2.6.2) when images were added to the menu without telling keyBinder about it.
Turn off keyBinder (or make sure it's recompiled) and see if the problem goes away.
stahta01:
Here's the only plugins I have on
BYO Games
Compiler
Copy strings to clipboard
Debugger
Dev-C++ devpak updater/installer
Dragscroll
Tim S
Note: I just enabled all of the plugins and it still looks good.
I am downloading a new copy of wxWidgets 2.6.3 because I can NOT find one that I have not patched.
I am going to rebuild it from scratch and see if I still get good results.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version