Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Refixed wxWidget Patch: menu items with icon not correctly aligned (since wx263)

<< < (9/11) > >>

killerbot:
these are based on the wx guys solution to the problem. Since I once tried an earlier attempt of you (graying out of icons), but then th first letter could duplicated. Is this now a new way. Just to be sure, I don't try out twice the same ;-)

stahta01:
Yes, this one does not double the first letters.

All my testing was with both of these patches applied.

Tim S

Edit: Before i was testing each patch by itself and discovered an problem of double the first letters happened when both patches where applied. This was because the alignment patch had code issues.



killerbot:
I have build  new wx dll by applying these 2 patches on the wx263p2 code and have tested with revision 3295 (rather old !!!). these are the results :
 - menus (with or without) icons alligned correctly
 - icons grayed out  in the menu as they should be
 - 90% of the icons are gone (due to keybinder)

updating my CB now to the latest revision, will adjust this post with the new results.
[EDIT : test finished]
with the latest svn revision 3516 : all is OK (all icons present) !!   :D :D :D

Pecan:

--- Quote from: killerbot on January 20, 2007, 03:13:50 pm ---I have build  new wx dll by applying these 2 patches on the wx263p2 code and have tested with revision 3295 (rather old !!!). these are the results :
 - menus (with or without) icons alligned correctly
 - icons grayed out  in the menu as they should be
 - 90% of the icons are gone (due to keybinder)

updating my CB now to the latest revision, will adjust this post with the new results.

--- End quote ---

I think you'll find that TimS's fix to keybinder to match his wxWidgets fixes occured in SVN 3443.

killerbot:
@Tim : did the wx guys already fix the issue that relates to our problem where the replace button on the toolbar in windows being incorrect and showing the find button ??

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version