Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Crash in revision 3412 when disabling plugin

<< < (2/2)

Pecan:
I want to mention that I had a similar problem with menuItems with keyBinder.
The original keyBinder assumed that menuItems pointers were always static  and valid.

This is not true in CB, or any other app that removes/rewrites/changes the menuItems.  I had to change keyBinder to *always* lookup (verify) the menuItem first. Even the menuItems ID's change in CB. In CB, the menuItem may not be there, or its properties changed in such a way that the menuItem was reallocated.

When CB added bit images to the menu items, I stepped (gdb) into places where the menuItem was deleted/destroyed and reallocated. I had to change keyBinder to match the situation.

I also noticed that a menuItems address can be returned incorrectly even when a Destroy has been called on it, if the call takes place too fast after the destroy.

I don't know if any of the above even applies, just wanted to mention it.

stahta01:
Plugin disable Crash report
 OS Windows XP SP2
 wxW cvs 2.6_BRANCH
 C::B SVN 3440 + Patches
   Patches applied to menuitemsmanager and codecompletion

[ Patch #1774 ] Plugin disable Crash issue partial fix
https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1774&group_id=5358

Test procedure:

Start with code Completion Plugin OFF
Start with suspected plugins OFF
Suspected Plugins Are:
Code Snippets
Copy Strings to Clipboard
Dev-C++ Devpak Updater
Code Profiler
Source Exporter
1a. disable plugin under test
1b. wait about 2 seconds
1c. enable plugin under test
2. repeat step 1a through 1c
3. repeat step 1a through 1c
4a. enable Completion Plugin 
4b. wait about 2 seconds
4c. disable Completion Plugin 
5. repeat step 4a through 4c
6. repeat step 4a through 4c

Results of tests will be updated in a short time after I re-run them.
The only one to fail on the re-testing using 2 sec time between was
Dev-C++ Devpak Updater

Tim S

killerbot:

--- Quote ---[ Patch #1774 ] Plugin disable Crash issue partial fix
https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1774&group_id=5358

--- End quote ---
Why do you call it partial ?

stahta01:

--- Quote from: killerbot on December 30, 2006, 10:25:55 am ---
--- Quote ---[ Patch #1774 ] Plugin disable Crash issue partial fix
https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1774&group_id=5358

--- End quote ---
Why do you call it partial ?

--- End quote ---

Because it still crashes about 10 to 30 % of what it used to.

Also, Dev-C++ Devpak Updater still has major issues.

Tim S

Navigation

[0] Message Index

[*] Previous page