User forums > General (but related to Code::Blocks)

3 simple thoughts

<< < (5/7) > >>

tiwag:

--- Quote from: sethjackson on November 29, 2006, 07:18:25 pm ---Now to the screenshots....

--- End quote ---


http://img362.imageshack.us/img362/6352/examplejb9.png


http://img125.imageshack.us/img125/5813/example2oi4.png

rjmyst3:
The drop-down arrow is not drawn correctly if the wxFNB_NO_X_BUTTON style is used.

I looked at the source, and it seems that the same bitmap (m_xBgBmp) is used to draw the background for both the drop-down arrow and the x button, and if the x button is not drawn, then the background bitmap is not initialized correctly, thus the background is all black. (I think, eran will know for sure).

sethjackson:
So it is a bug in wxFNB?

rjmyst3:
yes, it is a bug in wxFNB

here is a patch to fix it:

--- Code: ---Index: renderer.cpp
===================================================================
--- renderer.cpp (revision 3)
+++ renderer.cpp (working copy)
@@ -205,7 +205,7 @@
  xbmp.SetMask(new wxMask(xbmp, MASK_COLOR));
  // erase old bitmap
  int posx = GetDropArrowButtonPos( pc );
- dc.DrawBitmap(m_xBgBmp, posx, 6);
+ dc.DrawBitmap(m_rightBgBmp, posx, 6);
 
  // Draw the new bitmap
  dc.DrawBitmap(xbmp, posx, 6, true);

--- End code ---

Belgabor:
While we're collecting things for eran to fix/add, why not add a rightclick menu to the arrows like Firefox 2 has?
(For those who don't know, Firefox 2 shows a list of the tabs hidden in the respective direction if you right-click an arrow)

Navigation

[0] Message Index

[#] Next page

[*] Previous page