Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Patches to compile and link C::B against wxWidgets 2.8.0
stahta01:
--- Quote from: killerbot on December 18, 2006, 09:13:17 pm ---Hello all you wx 2.7.x and 2.8.x folks.
I am going to apply patches (one at a time) to get it to build for wx, only if they meet the following conditions (if those are acceptable conditions) :
1) all wx 2.7.x patches should be considered not existing [2.7.x are development series, not official release series]
-> so please adjust all your patches for 2.8 and remove all references to 2.7.x, I'd prefer not to look at any 2.7 patch at berlios and like to close it without looking at it. I'd prefer not tp spend time on them and then in the end find out that a little thing might have changed in the official 2.8
2) as a result of 1), I'd like to see all ifdef constructs referring to 2.7.x removed, I think we should not ifdef polute our code on unofficial versions, and certainly not versions we won't support, don't take this as an insult, I am very thankful for all the hard work, but in the end all that research will pay back in the "official 2.8 patches" ;-)
--- End quote ---
I understand the above info and will change all the 2.7.x values to 2.8.0; and I will redo all the 2.7 patches as 2.8 patches. Therefore you can close the 2.7 ones from me. And, afb patches 1630 and 1627.
https://developer.berlios.de/patch/?func=detailpatch&patch_id=1630&group_id=5358
https://developer.berlios.de/patch/?func=detailpatch&patch_id=1627&group_id=5358
--- Quote from: killerbot on December 18, 2006, 09:13:17 pm ---3) all patches should describe what they are doing :
a) how comes it does not work without the patch (so what did 2.8 break) [== the why]
b) a little explanation how wx 2.8 now does it
c) whatever information you can give to make our life easier to understand and apply the patches without doing the research ourself from scratch
--- End quote ---
I will add explanations to the patches.
--- Quote from: killerbot on December 18, 2006, 09:13:17 pm ---4) OPEN QUESTION : I guess most linux distros are now already somewhere in the 2.6.x line [x can still be 1 or 2 or 3 !!!], can we kick out 2.4.x specific things ?
--- End quote ---
The values WXWIN_COMPATIBILITY_2_4 is actually a 2.6 item, so it can NOT be removed. But, WXWIN_COMPATIBILITY_2_2 can be if it exists somewhere.
--- Quote from: killerbot on December 18, 2006, 09:13:17 pm ---5) unfortunately we can't use anything yet of the new functionalities of wx 2.8 since probably it will take 6 months to 1 year until the major linux distros come with a newer version [some example : I think they have new about boxes or so ...]
--- End quote ---
I understand this.
--- Quote from: killerbot on December 18, 2006, 09:13:17 pm ---Let me stress one thing : many many thanks to all of you who already sorted things out on what happened with wx ;-) , now it's just a little documentation step and cleaning.
--- End quote ---
Thanks for the thank you.
Tim S
stahta01:
I am finished with the 2.8 changes and added reasons etc. If you want more info just ask.
Could you start on Patch #1732; it is causing a lot of work because the file has line ending issues so it is hard to do the diffs on it.
Thanks, Tim S
[ Patch #1732 ] keybinder plugin patches for wxWidgets 2.8 Submitted By: stahta01 based on afb work.
https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1732&group_id=5358
Pecan:
--- Quote from: stahta01 on December 19, 2006, 01:00:32 pm ---I am finished with the 2.8 changes and added reasons etc. If you want more info just ask.
Could you start on Patch #1732; it is causing a lot of work because the file has line ending issues so it is hard to do the diffs on it.
Thanks, Tim S
[ Patch #1732 ] keybinder plugin patches for wxWidgets 2.8 Submitted By: stahta01 based on afb work.
https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1732&group_id=5358
--- End quote ---
I would rather not make any 2.7.x or 2.8.x changes to keyBinder until CB supports it, and certainly not until RC3 is out.
pecan
stahta01:
--- Quote from: Pecan on December 19, 2006, 03:48:42 pm ---I would rather not make any 2.7.x or 2.8.x changes to keyBinder until CB supports it, and certainly not until RC3 is out.
pecan
--- End quote ---
Could you then fix the line ending issues with this file then. I have to convert from DOS to Mac line ending and then from Mac to DOS line endings to get good diffs on this file. File: src/plugins/contrib/keybinder/keybinder.cpp
Thanks for the good work on Code::Blocks, and waiting till RC3 is out is fine with me; and you only need to fix the line ending issue the next time you update the file.
Tim S
Pecan:
--- Quote from: stahta01 on December 19, 2006, 04:24:58 pm ---Could you then fix the line ending issues with this file then. I have to convert from DOS to Mac line ending and then from Mac to DOS line endings to get good diffs on this file. File: src/plugins/contrib/keybinder/keybinder.cpp
Tim S
--- End quote ---
I don't understand. Do you mean that I should change keyBinder to Mac line endings? What about the Linux and Windows users?
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version