Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Patches to compile and link C::B against wxWidgets 2.8.0

<< < (5/25) > >>

afb:

--- Quote from: mandrav on November 24, 2006, 11:56:07 am ---... Until then, wx2.6 will be used for C::B development.
Of course, patches that allow building with wx2.8 too are fine ...
--- End quote ---

That is what we are discussing, yes :-)

afb:

--- Quote from: stahta01 on November 24, 2006, 11:08:51 am ---FYI:

The only thing that seems to need WXWIN_COMPATIBILITY_2_4 set to 1 is the use of wxHIDE_READONLY. I have submitted a patch to guard all the locations that it is used in.

--- End quote ---

Isn't it easier to just #define it to 0 for newer wxWidgets, instead of guarding it everywhere ?


--- Code: ---#if !WXWIN_COMPATIBILITY_2_4
#define wxHIDE_READONLY 0
#endif
--- End code ---

sethjackson:

--- Quote from: afb on November 24, 2006, 12:27:32 pm ---
--- Quote from: stahta01 on November 24, 2006, 11:08:51 am ---FYI:

The only thing that seems to need WXWIN_COMPATIBILITY_2_4 set to 1 is the use of wxHIDE_READONLY. I have submitted a patch to guard all the locations that it is used in.

--- End quote ---

Isn't it easier to just #define it to 0 for newer wxWidgets, instead of guarding it everywhere ?


--- Code: ---#if !WXWIN_COMPATIBILITY_2_4
#define wxHIDE_READONLY 0
#endif
--- End code ---

--- End quote ---

IIRC we use that flag in the file dialogs somewhere........

stahta01:

--- Quote from: afb on November 24, 2006, 12:27:32 pm ---Isn't it easier to just #define it to 0 for newer wxWidgets, instead of guarding it everywhere ?


--- Code: ---#if !WXWIN_COMPATIBILITY_2_4
#define wxHIDE_READONLY 0
#endif
--- End code ---

--- End quote ---

Yes, it is much easier, but it seemed to make C::B unstable. I have done some more testing and C::B is unstable when WXWIN_COMPATIBILITY_2_4 is set to 0. Why, I don't know yet. I added guards around the wxHIDE_READONLY so setting it to zero was not the cause. But, setting WXWIN_COMPATIBILITY_2_4 to zero was.

Tim S

afb:

--- Quote from: stahta01 on November 24, 2006, 04:36:44 pm ---C::B is unstable when WXWIN_COMPATIBILITY_2_4 is set to 0.
--- End quote ---

The one I set to zero was wxHIDE_READONLY constant, not WXWIN_COMPATIBILITY_2_4...

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version