Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Patches to compile and link C::B against wxWidgets 2.8.0

<< < (21/25) > >>

Pecan:
RE: patch1732 to keybinder.

Looking at defs.h for 2.8.0,

--- Code: ---    WXK_PAGEUP,
    WXK_PAGEDOWN,
#if WXWIN_COMPATIBILITY_2_6
    WXK_PRIOR = WXK_PAGEUP,
    WXK_NEXT  = WXK_PAGEDOWN,
#endif

--- End code ---

I don't get the purpose of the patch unless the intent is to run without 2.6 compatibilty.

Even if that were true, the patch hacks the problem and causes others (since new code will have to be written to avoid current dependency on wxk_prior/next).

Any explanation?

stahta01:

--- Quote from: Pecan on December 29, 2006, 07:16:05 pm ---RE: patch1732 to keybinder.

Looking at defs.h for 2.8.0,

--- Code: ---    WXK_PAGEUP,
    WXK_PAGEDOWN,
#if WXWIN_COMPATIBILITY_2_6
    WXK_PRIOR = WXK_PAGEUP,
    WXK_NEXT  = WXK_PAGEDOWN,
#endif

--- End code ---

I don't get the purpose of the patch unless the intent is to run without 2.6 compatibilty.

Even if that were true, the patch hacks the problem and causes others (since new code will have to be written to avoid current dependency on wxk_prior/next).

Any explanation?



--- End quote ---

The values need to be gated by WXWIN_COMPATIBILITY_2_6 because they are being used in a switch statement, if NOT done you get a compile error on duplicate CASE values.

Tim S

Pecan:

--- Quote from: stahta01 on December 29, 2006, 08:59:14 pm ---
The values need to be gated by WXWIN_COMPATIBILITY_2_6 because they are being used in a switch statement, if NOT done you get a compile error on duplicate CASE values.

Tim S

--- End quote ---

Yes, I finally get it. Commit 3440.
This does not mean that keyBinder will work properly with 2.8.
It just means no compiler errs.
 

David Perfors:
We know, the most of the patches are to avoid compiler errors.

In fact, is it true that icons on the toolbar that should be grey, are invisible (well they are grey, but most of the time the whole area of the icon is dark grey)

stahta01:
Number of Warnings is from Windows XP Unicode wxW2.8 CVS Label WX_2_8_MICROFIX_BRANCH;
  compiled with minGW GCC 3.4.2 API 3.8

Terms:
  Main: the code compiled by project file CodeBlocks.cbp
  Contrib: the code compiled by workspace file ContribPlugins.workspace
  SDK: the code under folder src/sdk
  Main Plugins:the code under src/plugins, but NOT under src/plugins/contrib
  Contrib Plugins:the code under src/plugins/contrib
  Core: the code under src/src


--- Code: ---Number      Area       
 87         Main
 22         Contrib
109         Total

--- End code ---


--- Code: ---Number      Section
  7         SDK/wxscintilla
 13         SDK/wxPropertyGrid
  6         SDK/wxFlatNotebook
 24         SDK other
  8         Core
 14         MainPlugins/Compiler
  4         MainPlugins/Debugger
  3         MainPlugins/Code-completion
  2         MainPlugins/Class wizard
  4         MainPlugins/Scripted wizard
  2         MainPlugins/To-do
  3         ContribPlugins/EnvVars Plug-In
  5         ContribPlugins/C::B KeyBinder
  8         ContribPlugins/Exporter/wxPdfDocument
  6         ContribPlugins/wxSmith


--- End code ---

Sections NOT worth patching because section is maintained by external group
    SDK/wxscintilla
    SDK/wxPropertyGrid
    SDK/wxFlatNotebook
    ContribPlugins/Exporter/wxPdfDocument

 Note: I am working on a patch to upgrade wxPropertyGrid to a newer version 1.2.x

Deprecated methods NOT worth patching as long as C::B uses wxWidgets 2.6.x
  wxWindow::SetBestFittingSize
  wxWindow::GetBestFittingSize
  wxPathList::Member
  wxRect::Inside
  ::wxGetAccelFromString

Note: I plan to patch the MainPlugin/Compiler use of deprecated methods wxStartTimer & wxGetElapsedTime in a separate patch.

Totals after warning reduction patches and module upgrade patches applied
[Totals being ran at current time, will update totals after run is done.]

--- Code: ---Number      Area       
 29         Main
 22         Contrib
 51         Total

--- End code ---


--- Code: ---Number      Section
  7         SDK/wxscintilla
  0         SDK/wxPropertyGrid
  6         SDK/wxFlatNotebook
  1         SDK other
  4         Core
  7         MainPlugins/Compiler
  3         MainPlugins/Debugger
  1         MainPlugins/Code-completion
  0         MainPlugins/Class wizard
  0         MainPlugins/Scripted wizard
  0         MainPlugins/To-do
  3         ContribPlugins/EnvVars Plug-In
  5         ContribPlugins/C::B KeyBinder
  8         ContribPlugins/Exporter/wxPdfDocument
  6         ContribPlugins/wxSmith


--- End code ---

Tim S

Navigation

[0] Message Index

[#] Next page

[*] Previous page