Author Topic: Will patches to compile and link C::B against wxWidgets 2.7.1 be accepted?  (Read 55648 times)

Offline stahta01

  • Lives here!
  • ****
  • Posts: 7582
    • My Best Post
I am going to try to get codeblocks to compile and link using wxWidgets 2.7.1. If I am able to get it to compile and link, will you accept patches to do this? Or will you just reject them as not needed because 2.7.x in just a development branch? Note, I understand that my patches has to be well written and follow the guidelines. And, that the patches will have a very low priority of being applied. I just wish to make sure that it is worth my time to create the patches; if you plan to reject all patches for 2.7.x branches then it is not worth the effort to create them.

Tim S
C Programmer working to learn more about C++ and Git.
On Windows 7 64 bit and Windows 10 64 bit.
--
When in doubt, read the CB WiKi FAQ. http://wiki.codeblocks.org

Offline Ceniza

  • Developer
  • Lives here!
  • *****
  • Posts: 1441
    • CenizaSOFT
Re: Will patches to compile and link C::B against wxWidgets 2.7.1 be accepted?
« Reply #1 on: November 01, 2006, 03:07:52 am »
Well, if your patches don't break compatibility with 2.6.x, and don't cause any side effect in C::B, they could be considered and should ease the future transition to the next stable version of wx, but I cannot assure you anything.

Have in mind some problems compiling C::B with 2.7.x are in 3rd party libraries, so every time we get an updated version of those libraries the patches would need to be applied again till those libraries become compilable with 2.7.x. I think it's the biggest problem.

I don't know what the other devs think, but I would like to give it a try :)

Offline mandrav

  • Project Leader
  • Administrator
  • Lives here!
  • *****
  • Posts: 4315
    • Code::Blocks IDE
Re: Will patches to compile and link C::B against wxWidgets 2.7.1 be accepted?
« Reply #2 on: November 01, 2006, 08:36:36 am »
Like Ceniza said, it depends on what the patches do. The top requirement is that it doesn't break 2.6 compatibility.
Another thing is the patch complexity. If it takes a complex patch to add 2.7 support, we might as well wait for the official 2.8. Because the 2.7 API *will* change until it becomes 2.8 and we 'd have to keep up with these changes all the time, with no good reason to.
Be patient!
This bug will be fixed soon...

Offline afb

  • Developer
  • Lives here!
  • *****
  • Posts: 884
Re: Will patches to compile and link C::B against wxWidgets 2.7.1 be accepted?
« Reply #3 on: November 01, 2006, 09:52:09 am »
One reason might be that wxExecute hangs on Mac OS X Intel
using wx 2.6.3, while it works just fine when using wx 2.7.1...
(this is the showstopper bug that makes wxMac useless on x86)
So I would very much welcome such a patch, at least to try it.

But you better hurry up, since wx 2.7.2 is just around the corner! :-)

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5490
Re: Will patches to compile and link C::B against wxWidgets 2.7.1 be accepted?
« Reply #4 on: November 01, 2006, 09:52:36 am »
I would wait, on the new wxWidgets blog, I could understand that wx 2.8 is very close !!
Maybe one or two more weeks. I would focus on that and hopefully it fixes a bunch of bugs and not introduce new ones.
That's what I don't like about wxWidgets, they don't fix the bugs easily (unicode wxString::<<  problems, the misaligned menus when a menu entry has an icon and so on :-( :-(  )

Offline David Perfors

  • Developer
  • Lives here!
  • *****
  • Posts: 560
Re: Will patches to compile and link C::B against wxWidgets 2.7.1 be accepted?
« Reply #5 on: November 01, 2006, 10:04:43 am »
I would wait, on the new wxWidgets blog, I could understand that wx 2.8 is very close !!
Maybe one or two more weeks.
Where did yuo find that information? I didn't read anything about that...
OS: winXP
Compiler: mingw
IDE: Code::Blocks SVN WX: 2.8.4 Wish list: faster code completion, easier debugging, refactoring

Offline afb

  • Developer
  • Lives here!
  • *****
  • Posts: 884
Re: Will patches to compile and link C::B against wxWidgets 2.7.1 be accepted?
« Reply #6 on: November 01, 2006, 10:17:52 am »
Where did yuo find that information? I didn't read anything about that...

http://sourceforge.net/forum/forum.php?forum_id=622756
Quote
12th October 2006: wxWidgets 2.7.1 (a development release) is now available for download via http://www.wxwidgets.org/downloads.
 
The main changes since 2.7.0 are detailed below. We would be grateful for testing as we work towards 2.8.0 release within the next few weeks. However please be aware that 2.7.1 is not production quality.


sethjackson

  • Guest

Offline stahta01

  • Lives here!
  • ****
  • Posts: 7582
    • My Best Post
Re: Will patches to compile and link C::B against wxWidgets 2.7.1 be accepted?
« Reply #8 on: November 01, 2006, 06:55:34 pm »
I have started work on the code changes to make C::B compile against wxWidgets 2.7.1 only under windows.
I have reached a point where I can't proceed without more research or waiting till bugs in wxWidgets 2.7.1 are fixed. (They may not have bugs in the code, but the help/documentation file does not agree with the code.)

For now I am going to work on getting the code changes, I have done, up to standard to make patches for me to submit; this is while I wait for 2.7.2 to fix the wxDialog bugs/documentation (cut and patch changes in header to header; code was removed from wx/msw/dialog.h that needed to be moved to wx/dialog.h; or a least a poster to a thread implied that was the cause) that were created in 2.7.1.

Tim S
C Programmer working to learn more about C++ and Git.
On Windows 7 64 bit and Windows 10 64 bit.
--
When in doubt, read the CB WiKi FAQ. http://wiki.codeblocks.org

Offline afb

  • Developer
  • Lives here!
  • *****
  • Posts: 884
Re: Will patches to compile and link C::B against wxWidgets 2.7.1 be accepted?
« Reply #9 on: November 01, 2006, 07:03:32 pm »
Quote
One reason might be that wxExecute hangs on Mac OS X Intel
using wx 2.6.3, while it works just fine when using wx 2.7.1...

On second thought this is a lame reason. Might as well work
around the bug on wx 2.6.3, or wait until the 2.6.4 release...

takeshimiya

  • Guest
Re: Will patches to compile and link C::B against wxWidgets 2.7.1 be accepted?
« Reply #10 on: November 01, 2006, 07:55:15 pm »
Quote
One reason might be that wxExecute hangs on Mac OS X Intel
using wx 2.6.3, while it works just fine when using wx 2.7.1...

On second thought this is a lame reason. Might as well work
around the bug on wx 2.6.3, or wait until the 2.6.4 release...

Has this bug been confirmed that is a bug on wx 2.6.x ? I'm asking because I don't seem to have problems with wxExecute(), neither DialogBlocks which is compiled with wx 2.6.3 also I think, but it might be coincidence.

If it's a bug on wx 2.6 and you can confirm it has been solved on 2.7, a diff between those revisions should reveal the changes, and you could backport the changes to 2.6.3, as I don't think a 2.6.4 is planned anytime soon.

Offline afb

  • Developer
  • Lives here!
  • *****
  • Posts: 884
Re: Will patches to compile and link C::B against wxWidgets 2.7.1 be accepted?
« Reply #11 on: November 01, 2006, 08:10:27 pm »
Has this bug been confirmed that is a bug on wx 2.6.x ? I'm asking because I don't seem to have problems with wxExecute(), neither DialogBlocks which is compiled with wx 2.6.3 also I think, but it might be coincidence.

As I noted in the bug, I was able to reproduce it in the wx 2.6.3 sample, but in the wx 2.7.1 sample the bug was gone. Do you have such a wxExecute demo I could try ?

And it seem to coincide with this entry from the changelog:
Code
- Fixed non-detection of process termination on Intel Macs by
polling for process termination in a separate thread.

BTW:
Why are there no more releases of the stable wxWidgets ?

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5490
Re: Will patches to compile and link C::B against wxWidgets 2.7.1 be accepted?
« Reply #12 on: November 01, 2006, 08:12:55 pm »
because the next stable one will be 2.8.0, let's hope it's this week or next week

Offline afb

  • Developer
  • Lives here!
  • *****
  • Posts: 884
Re: Will patches to compile and link C::B against wxWidgets 2.7.1 be accepted?
« Reply #13 on: November 01, 2006, 08:21:35 pm »
because the next stable one will be 2.8.0, let's hope it's this week or next week

OK, so why are there no more releases of the legacy wxWidgets then ? ;-)

takeshimiya

  • Guest
Re: Will patches to compile and link C::B against wxWidgets 2.7.1 be accepted?
« Reply #14 on: November 01, 2006, 08:27:27 pm »
Do you have such a wxExecute demo I could try ?
Not at hand unfortunately,

And it seem to coincide with this entry from the changelog:
That's really great! Could you back-port the changes? I would be happy to have for the first time a C::B that can run programs on Carbon/Intel :D

BTW:
Why are there no more releases of the stable wxWidgets ?
AFAIK 2.7.2 is due to be released officially probably tomorrow (all wxAui classes will be renamed),
and 2.8 RC will be around november, 13,

OK, so why are there no more releases of the legacy wxWidgets then ? ;-)
There might be a 2.6.4, but I don't think anytime soon, if ever.