User forums > Nightly builds

The 12 october 2006 build is out.

<< < (4/13) > >>

artoj:

--- Quote from: thomas on October 13, 2006, 12:27:37 pm ---I mean, this is a change that would better be placed in the *real* codebase, as those problems will affect any application, not just ours. I think Arto won't object to adopt changes that are obviously advantageous to everybody ;)

--- End quote ---

Well, this is (should be) a Bazaar after all.

killerbot:
this weekend I will 'document [== readable text]' the changes we made (the number is rather small, but don't look at the patch, it's awfull because of white space stripping), so then it will be more clear.

mandrav:

--- Quote from: thomas on October 13, 2006, 12:27:37 pm ---
--- Quote from: mandrav on October 13, 2006, 12:13:17 pm ---Our changes are not that simple ;).

For example, the latest patching I did in wxFNB was to move the EVT_PAGE_SELECTION_CHANGED and EVT_PAGE_SELECTION_CHANGING events to the SetSelection() function, instead of in the OnLeftDown(). The way it was, we were only informed about page selection changing only when the user used the mouse to change pages. But if you used Ctrl-Tab/Shift-Ctrl-Tab we never knew you changed the page, causing all kinds of side-effects for us...

--- End quote ---
But why is the rum gone!

I mean, this is a change that would better be placed in the *real* codebase, as those problems will affect any application, not just ours. I think Arto won't object to adopt changes that are obviously advantageous to everybody ;)

Are there any other major changes that we need besides that?

--- End quote ---

Yes, of course itwould be better if eran (not Arto ;)) would incorporate them in the codebase but until he does we have no other option.
The other changes, I did them quite some time back now and I can't remember them without looking at the code...
Anyway, killerbot will document them and we 'll see.

tiwag:

--- Quote from: killerbot on October 13, 2006, 01:12:40 pm ---this weekend I will 'document [== readable text]' the changes we made (the number is rather small, but don't look at the patch, it's awfull because of white space stripping), so then it will be more clear.

--- End quote ---

if you use WinMerge you can suppress all white-space changes and find out the "real" patch

rjmyst3:

--- Quote ---In particular, if you used Subversion, we could simply put an externals definition onto the wxFlatNotebook directory which points to your "stable" branch, and we would never have to worry about updating anything any more. You can develop the same way as before, and whenever you deem your source tree "stable", you make a svn copy to "stable".
The updates will magically appear in every project using wxFNB.
--- End quote ---

I agree with thomas. As a developer of another project using wxFNB, we too would appreciate wxFNB in svn. But even more, we would be overjoyed to see mandrav's patches in eran's codebase - we too have a problem with only getting page changed events when the pages are clicked ...

Another patch that we got to "harvest" from the codeblocks team is prevention of drag'n'drop to foreign flatnotebooks - I've already submitted this patch to eran (with credit to you guys) and he has implemented it.

To summarize, if we both external'd the source from eran's svn repository, I think everyone would be better off.

Navigation

[0] Message Index

[#] Next page

[*] Previous page