User forums > Help
How do I get recursively adding files to work?
mandrav:
--- Quote from: tzonkov on August 15, 2006, 09:31:31 am ---I figured I can change the directory name and get it to work. I guess I can add a request to remove that harcoded filter. Since there is the wildcard filter, the hardcoded list of ommissions should not be needed any longer. Amy I correct in assuming this?
--- End quote ---
No. Using a directory named "CVS" is bad practice. You should avoid that at all costs. It can make cvs (the program) behave badly. If you still want to use it, rename it to something else like "CVS_files", for example...
mandrav:
--- Quote from: Takeshi Miya link=topic=3817.msg30193#msg30193 --- EDIT: I think this shall not be hard-coded.
--- End quote ---
This will always be hardcoded, Takeshi.
These are well known directories used by well-known SCMs (at least in the open source world). If you want, disable this filtering code and try adding multiple files from a directory which is under revision control by either svn or cvs (especially the last). You 'll be thankful C::B hides it from you all this time...
What should be added though, is a warning text in the multiple select dialog stating the fact that some files were ignored for that reason.
takeshimiya:
--- Quote from: mandrav on August 15, 2006, 09:59:11 am ---
--- Quote from: Takeshi Miya link=topic=3817.msg30193#msg30193 --- EDIT: I think this shall not be hard-coded.
--- End quote ---
This will always be hardcoded, Takeshi.
These are well known directories used by well-known SCMs (at least in the open source world). If you want, disable this filtering code and try adding multiple files from a directory which is under revision control by either svn or cvs (especially the last). You 'll be thankful C::B hides it from you all this time...
--- End quote ---
I was thinking in another (way more) possibilities for not necessaringly hardcoding them, such as ".bazaar", ".anyothercontrolsystem", "_svn", ".obj", and well, you can imagine a lot more.
--- Quote from: mandrav on August 15, 2006, 09:59:11 am ---What should be added though, is a warning text in the multiple select dialog stating the fact that some files were ignored for that reason.
--- End quote ---
They would continue to be hard-coded, but at least it would be transparent for the user.
In general I don't consider good (but handy when time is scarce, altrough it doesn't pays in the end) hard-coding these kind of values (paths, filenames, wildcards, etc) as they change a lot in a lot of different systems.
EDIT: The point was, that with not hardcoding them, we eliminate all future possible requests for "hey please add support for x path which I use often and would like to see hidden as .svn" and "hey please remove support for CVS since in my scripts relies on it".
Well everything's fine when one can change them at runtime, but when it requieres recompilation it can become a pain, since you don't have always the code at hand.
mandrav:
--- Quote ---The point was, that with not hardcoding them, we eliminate all future possible requests for "hey please add support for x path which I use often and would like to see hidden as .svn" and "hey please remove support for CVS since in my scripts relies on it".
--- End quote ---
I think you 're missing the point here.
We do filter these specific values because they are very well-known. There was never the intention to make this configurable.
Maybe you want to make the C::B project/workspace extensions configurable too?
takeshimiya:
--- Quote from: mandrav on August 15, 2006, 10:44:33 am ---Maybe you want to make the C::B project/workspace extensions configurable too?
--- End quote ---
Well, not configurable, but in the snippet above I can't see for example ".workspace" being filtered out (that was the point).
OT: I think I can see why the extension ".workspace" is not included, it's well-known, but it's also very common (every program seems to want it associated) so it was safer not to include.
In the snippet I'm missing also the constant for the project files (and workspaces, .layouts, and so on), and some kind of moduladirity (for reusability) like GetProjectExtensions() (including .dsw, .dsp, ...) and GetSCMCommonPaths().
But, that moduladirity is not really needed (here, in this case) if they can be either configurable, or scriptable.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version