Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Aborting compilation seems to be broken
mdelfede:
--- Quote from: tiwag on August 03, 2006, 11:02:10 am ---
--- Quote from: thomas on August 03, 2006, 10:08:23 am ---... if we stop adding any more stdout data to the log window after the user has hit "abort"? ...
--- End quote ---
extension :
1st press of Abort button: disable output logging
if the Abort button is pressed subsequently later on (let's say more than 2 times in one second) : kill the process
--- End quote ---
What about another alertbox asking if you REALLY want to kill the process, and only on windoze compilations ?
So, for example, stop the log output at first, then prompt an alertbox asking if you want to kill the process too, with little explanation of risks.
Another possibility would be to put what to do in environment options, so user can choose if he wants the normal behaviour, the 'stop output' behaviour or the 'kill it' one.
Ciao
Max
mandrav:
This conversation is pointless.
What's slow, is the error messages that are regex-parsed and scrolling fast. Thomas' patch disables them, so abort time will be instant in most cases.
We won't add "Just Another Configuration Option" just for the heck of it. It just doesn't make sense...
tiwag:
Hi thomas,
it makes the following difference
with CB rev_2801 i had to wait until all warnings got catched ... 8 minutes !!!
--- Code: ----------------- Build: Debug in wx_console ---------------
mingw32-g++.exe -W -pipe -mthreads -include wx_pch.h -D__GNUWIN32__ -D__WXMSW__ -DWXUSINGDLL -DwxUSE_UNICODE -DUSE_PCH -g -Id:\wx263\include -Id:\wx263\lib\gcc_dll\mswu -Id:\wx263\contrib\include -ID:\MinGW\include -c wx_pch.h -o wx_pch.h.gch\Debug_wx_pch.h.gch
In file included from d:/wx263/include/wx/string.h:55,
from d:/wx263/include/wx/memory.h:20,
from d:/wx263/include/wx/object.h:25,
from d:/wx263/include/wx/wx.h:16,
from d:/wx263/include/wx/wxprec.h:54,
from ./wx_pch.h:9,
from <command line>:7:
d:/wx263/include/wx/buffer.h:96: warning: inline function 'wxCharBuffer::wxCharBuffer(const char*)' is declared as dllimport: attribute ignored.
d:/wx263/include/wx/buffer.h:96: warning: inline function 'wxCharBuffer::wxCharBuffer(const char*)' is declared as dllimport: attribute ignored.
...
Process terminated with status 0 (8 minutes, 12 seconds)
0 errors, 4490 warnings
--- End code ---
with your patch applied i got 39 sec. .... much better !!!!
--- Code: ----------------- Build: Debug in wx_console ---------------
mingw32-g++.exe -W -pipe -mthreads -include wx_pch.h -D__GNUWIN32__ -D__WXMSW__ -DWXUSINGDLL -DwxUSE_UNICODE -DUSE_PCH -g -Id:\wx263\include -Id:\wx263\lib\gcc_dll\mswu -Id:\wx263\contrib\include -ID:\MinGW\include -c wx_pch.h -o wx_pch.h.gch\Debug_wx_pch.h.gch
In file included from d:/wx263/include/wx/string.h:55,
from d:/wx263/include/wx/memory.h:20,
from d:/wx263/include/wx/object.h:25,
from d:/wx263/include/wx/wx.h:16,
from d:/wx263/include/wx/wxprec.h:54,
from ./wx_pch.h:9,
from <command line>:7:
d:/wx263/include/wx/buffer.h:96: warning: inline function 'wxCharBuffer::wxCharBuffer(const char*)' is declared as dllimport: attribute ignored.
d:/wx263/include/wx/buffer.h:96: warning: inline function 'wxCharBuffer::wxCharBuffer(const char*)' is declared as dllimport: attribute ignored.
...
Aborting process 0...
Process terminated with status 0 (0 minutes, 39 seconds)
0 errors, 436 warnings
--- End code ---
thanks thomas, fine improvement !
mandrav:
tiwag, you could also add the -Wfatal-errors which will stop on the very first error.
tiwag:
--- Quote from: mandrav on August 03, 2006, 12:53:16 pm ---tiwag, you could also add the -Wfatal-errors which will stop on the very first error.
--- End quote ---
i know this,
the reason why i posted all that stuff was,
that when you erroneously started a compilation with the wrong options,
you had to wait long (in my case 8 minutes) without possibility to abort the process.
this is now corrected with thomas' patch
thanks all
tiwag
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version