Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Wrong messages in "Build messages"

<< < (2/3) > >>

killerbot:
yes you can do that, the patches thread is a nice place for people to see if something already exists without having to go to berlios, and it can show up in forum search results.

iw2nhl:
I produced that code without knowing wxWidgets very well.
I noticed now that I left a "wxString::Format" that is not required (I just did copy-paste) because there is nothing to insert in the string.
Wrong line

--- Code: (cpp) ---    wxString msg = wxString::Format(_("errors found"));
--- End code ---

It should work, but it is not needed.

iw2nhl:
It works if the 2 lines that start with "wxString msg" are changed removing "wxString"
"wxString msg" --> "msg"

I noticed now that with latest SVN (and some nigthly ago) it shows correctly "1 error" if an error occurs because a file is not found.
So this patch is no more needed. Someone fixed the code in a better way.

Still remains the "Abort" fix to be done (if wanted).

killerbot:

--- Quote from: iw2nhl on July 28, 2006, 01:05:55 am ---It works if the 2 lines that start with "wxString msg" are changed removing "wxString"
"wxString msg" --> "msg"

I noticed now that with latest SVN (and some nigthly ago) it shows correctly "1 error" if an error occurs because a file is not found.
So this patch is no more needed. Someone fixed the code in a better way.

Still remains the "Abort" fix to be done (if wanted).

--- End quote ---

testing today, but I don't think that part of the code has been changed recently. Your suggested code was indeed incorrect, since you 2 declared in the if/else the local var msg which then died since it was out of scope.

killerbot:
I just checked and indeed in the build log it says in red : "Process terminated with status 1". So it show some indication of error.
On the other hand maybe we should stick with this, since we are not sure if every return type !=0 is indeed an indication of an error.

Navigation

[0] Message Index

[#] Next page

[*] Previous page