Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Really slow performance when deleting several lines

<< < (2/3) > >>

MortenMacFly:
I knew that this would happen - these lines are from me. :oops:
Anyway: mandrav: That's why I have proposed a RemoveBreakpoints method because only the debugger knows how to effectively remove breakpoints beyond the new EOF if lines are deleted from a file...
I still have my implementation of this at home... an interest?
With regards, Morten.

Edit: BTW: I just realiased that the TODO on top of the affected lines made in in SVN, too... :lol:

MortenMacFly:
...and while working on that: Please don't forget:
http://forums.codeblocks.org/index.php?topic=3261.msg25801#msg25801
...and:
http://forums.codeblocks.org/index.php?topic=3261.msg26709#msg26709
:lol:

mandrav:

--- Quote from: MortenMacFly on July 05, 2006, 02:08:16 pm ---I knew that this would happen - these lines are from me. :oops:
Anyway: mandrav: That's why I have proposed a RemoveBreakpoints method because only the debugger knows how to effectively remove breakpoints beyond the new EOF if lines are deleted from a file...
I still have my implementation of this at home... an interest?

--- End quote ---

I 'm working on it, as we speak.
I have opted for another route: I added the following function in the debugger plugins' interface:

--- Code: ---virtual void EditorLinesAddedOrRemoved(cbEditor* editor, int startline, int lines) = 0;

--- End code ---

If you think about it, it's really up to the debugger to stay in sync with the editor. Not the editor's job to keep bugging the debugger to keep in sync ;)

MortenMacFly:

--- Quote from: mandrav on July 05, 2006, 02:25:15 pm ---If you think about it, it's really up to the debugger to stay in sync with the editor. Not the editor's job to keep bugging the debugger to keep in sync ;)

--- End quote ---
I fully agree on that. And in fact I had nearly the same arguments to the method, maybe the naming was bad. I assume you are still going to call this method from inside "cbEditor::OnEditorModified", right?! Anyway... we'll see as time passes by... ;-)

mandrav:
OK, fix commited.
Much more simpler code, a lot faster and hopefully fixes all problems the old implementation had.
Morten, I 'm waiting for your comments.

Navigation

[0] Message Index

[#] Next page

[*] Previous page