User forums > Nightly builds

The 24 May 2006 build is out.

<< < (2/3) > >>

MortenMacFly:

--- Quote from: mandrav on May 25, 2006, 11:02:47 am ---OK, I 've found the cause in sdk/pipedprocess.cpp. The text stream we 're reading there, is using UTF8 conversion which is clearly the problem here.

--- End quote ---
I couldn't stand to point to: http://forums.codeblocks.org/index.php?topic=2910.msg22996#msg22996. It seems I haven't been so much wrong there... suprisingly... ;-)


--- Quote from: mandrav on May 25, 2006, 11:02:47 am ---Also, Morten, please check your test file again and tell us if it works now...

--- End quote ---
Fantastic! This fixes the issue with "Hähä"!!! :D :D :D ;-)

It seems today you are fixing really quite some nasty bugs - another success story. Good work!

Morten.

Ps.: Anyway: On my way to compile the new revision I got another crash. What I did was:
- Open C::B
- Open my C::B workspace (the C::B project plus all contrib plugins)
- Changing to Firefox and doing some reading while the workspace was loading
- Then... suddenly... in the background C::B crashed.
Please find the report file attached.

Pps.: I'm off for the rest of the weekend in case you wonder why it's getting silent... ;-)

[attachment deleted by admin]

chrisb:

--- Quote from: mandrav on May 25, 2006, 11:02:47 am ---Test compiling too. We wouldn't want to break what already works ;)

--- End quote ---
Hey.

I've updated codeblocks to rev2502 right now and noticed that a problem occurred compiling the new pipedprocess.cpp.
The compiler complained that no proper constructor was found.

After checking the file, I found out that you do not deal the case if there's no wx-Unicode support.
So i discover the rest of the file and write a short patch for it. It there's no support the "old" constructor will be invoked.

Consider it:

--- Code: ------ src/sdk/pipedprocess_old.cpp 2006-05-25 11:59:27.000000000 +0200
+++ src/sdk/pipedprocess.cpp 2006-05-25 12:02:06.000000000 +0200
@@ -174,7 +174,11 @@ bool PipedProcess::HasInput()
 
     if (IsErrorAvailable())
     {
-        cbTextInputStream serr(*GetErrorStream(), wxT(" \t"), wxConvLocal);
+        #if wxUSE_UNICODE
+        cbTextInputStream serr(*GetInputStream(), wxT(" \t"), wxConvLocal);
+        #else
+        cbTextInputStream serr(*GetErrorStream());
+        #endif
 
         wxString msg;
         msg << serr.ReadLine();
@@ -189,7 +193,11 @@ bool PipedProcess::HasInput()
 
     if (IsInputAvailable())
     {
+        #if wxUSE_UNICODE
         cbTextInputStream sout(*GetInputStream(), wxT(" \t"), wxConvLocal);
+        #else
+        cbTextInputStream sout(*GetErrorStream());
+        #endif
 
         wxString msg;
         msg << sout.ReadLine();

--- End code ---

MortenMacFly:

--- Quote from: mandrav on May 25, 2006, 11:02:47 am ---Also, Morten, please check your test file again and tell us if it works now...

--- End quote ---
I'm sorry to say this, but while working on that topic I found another two debugger issues that I have posted in a new thread because they are not related to this one. Please have a look here:
http://forums.codeblocks.org/index.php?topic=3197.0. :( :( :(
With best regards, Morten.

mandrav:

--- Quote from: MortenMacFly on May 25, 2006, 12:12:23 pm ---
--- Quote from: mandrav on May 25, 2006, 11:02:47 am ---Also, Morten, please check your test file again and tell us if it works now...

--- End quote ---
I'm sorry to say this, but while working on that topic I found another two debugger issues that I have posted in a new thread because they are not related to this one. Please have a look here:
http://forums.codeblocks.org/index.php?topic=3197.0. :( :( :(
With best regards, Morten.


--- End quote ---

Well, they 're irrelevant to the issues tracked here, so it's good that you found them :)

mandrav:

--- Quote from: chrisb on May 25, 2006, 12:12:05 pm ---
--- Quote from: mandrav on May 25, 2006, 11:02:47 am ---Test compiling too. We wouldn't want to break what already works ;)

--- End quote ---
Hey.

I've updated codeblocks to rev2502 right now and noticed that a problem occurred compiling the new pipedprocess.cpp.
The compiler complained that no proper constructor was found.

After checking the file, I found out that you do not deal the case if there's no wx-Unicode support.
So i discover the rest of the file and write a short patch for it. It there's no support the "old" constructor will be invoked.

--- End quote ---

Thanks :)
I won't use your patch (there's an easier way to fix this), but thanks for pointing out the isuue.

Navigation

[0] Message Index

[#] Next page

[*] Previous page