Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
wxFlatNotebook update + Patch
MortenMacFly:
--- Quote from: mandrav on May 05, 2006, 06:22:10 pm ---As I expected, the patch doesn't work correctly. That's why I wanted to test it myself.
--- End quote ---
mandrav: Correct me, if I'm wrong, but could it be that this bug also appears in the nightlys? Starting from v0.90 (C::B pathhed as from SVN) I tried to apply the changes done up to revision 1.30 to see when the issue appears. But when I compiled C::B again using the SVN version the bug did already appear. I thought it might have been a missing deletion of any file, did a re-build... again. Then I downloaded the latest nightly available and renamed "my" C::B folder. But when I run the nightly and do the steps you described the same thing happens. Are you aware of that?
If so I got you wrong because I thought this issue was introduced somewhere in between v0.90 and v1.30...?!
With regards, Morten.
PChris:
--- Quote from: MortenMacFly on May 07, 2006, 11:18:23 am ---
--- Quote from: mandrav on May 05, 2006, 06:22:10 pm ---As I expected, the patch doesn't work correctly. That's why I wanted to test it myself.
--- End quote ---
mandrav: Correct me, if I'm wrong, but could it be that this bug also appears in the nightlys? Starting from v0.90 (C::B pathhed as from SVN) I tried to apply the changes done up to revision 1.30 to see when the issue appears. But when I compiled C::B again using the SVN version the bug did already appear. I thought it might have been a missing deletion of any file, did a re-build... again. Then I downloaded the latest nightly available and renamed "my" C::B folder. But when I run the nightly and do the steps you described the same thing happens. Are you aware of that?
If so I got you wrong because I thought this issue was introduced somewhere in between v0.90 and v1.30...?!
With regards, Morten.
--- End quote ---
I can confirm this too...
This bug is also present on the old version.
Der Meister:
Confirmed even on Linux. Revision 2417, compiled with gcc 3.4.5 and wxGTK 2.6.2 (unicode).
TheTuxKeeper:
Same with rev2411 on Fedora (wxGTK 2.6.2 unicode + gcc 4.02). If you repeat these steps more than once the space is getting few pixels larger with each repetition of these steps until only few pixels of the headline are visible. Even the vertical scrollbar is gone :shock:
I forgot to save the last screenshot, but this one is only few times before the space isn't getting bigger anymore.
Der Meister:
I'm not quite sure what behaviour is intended. But this problem can be fixed with this little patch:
--- Code: ---Index: src/sdk/messagemanager.cpp
===================================================================
--- src/sdk/messagemanager.cpp (revision 2417)
+++ src/sdk/messagemanager.cpp (working copy)
@@ -332,7 +332,7 @@
if (show && !ls->visible)
{
// show
- m_pNotebook->InsertPage(id, log, ls->title, false);
+ m_pNotebook->InsertPage(id, log, ls->title, true);
SetLogImage(id, ls->bitmap);
ls->visible = true;
--- End code ---
This way the tab that will be shown again gets selected. I think this is not the originally intended behaviour but it at least works without the problem described here.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version