Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Found a few memory leaks

<< < (3/3)

thomas:

--- Quote ---But as you and rickg22 already said these change is neither needed nor a really good idea...
--- End quote ---
Actually, I think that it is not generally a bad idea. STL containers are a lot more transparent and less error-prone (for example, you cannot forget to include arrimpl.cpp because no such tampering is necessary). The class browser is able to follow a typedef, but it utterly fails on WX_DECLARE_XXX. It is also not immediately obvious what exactly some macros do (have to look at some of them for 20 seconds to understand). A typedef on a STL container is self-explanatory.

The same is true when you actually make a mistake (whatsoever) and have to read through unintellegible compiler errors that reference some code which you have never heard about coming from inside a container macro. Granted, STL error messages are not easy for a newbie either, but they are intellegible, because they are not just random garbage.

The problem with converting to STL containers is just that
a) we started using wx containers in the first place
b) it requires an unjustifiable amount of work to switch now (we simply don't have the time)
c) it is not feasonable in all places
d) it does not work with wxWidgets memory debugging (have to #undef new)

Der Meister:

--- Quote from: mandrav on March 29, 2006, 09:08:38 am ---DerMeister, thanks for the effort and the patch. Although it doesn't apply cleanly (it has failed hunks).

--- End quote ---
I just updated the patch. It should now apply to revision 2274 and only removes the memory-leaks and not the wx containers.

Navigation

[0] Message Index

[*] Previous page