Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

build bot in the github, I see one nice project

<< < (13/26) > >>

Grit Clef:

--- Quote from: ollydbg on September 23, 2024, 08:07:48 am ---
--- Quote from: Grit Clef on September 23, 2024, 05:48:09 am ---And in my repository, the svn revision and the wxWidgets version now can be Automatically detected.

--- End quote ---

Thanks for the info. My github action code for created the release package is mainly created by chatGPT, and has some flaws. I got some warning message like below:


--- Quote ---The following actions uses node12 which is deprecated and will be forced to run on node16: actions/create-release@v1, actions/upload-release-asset@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
--- End quote ---

I think I will use your method, and by adding some time stamp for the release.

Question: why do you add a cron section?


--- Code: ---  schedule:
    - cron: '0 0 7,14,21,28 * *'
--- End code ---

You want to run the github action every week? (chatGPT gives me the answer: the cron expression '0 0 7,14,21,28 * *' means that the job will run at midnight on the 7th, 14th, 21st, and 28th day of every month.)

--- End quote ---
Yes. Because then I won't need to run the Actions manually;
And your commands are accepted, thanks.

Grit Clef:
Oh, when I tried your command:
The result is, first 13571 came out and then an error:
Error: Process completed with exit code 141.

ollydbg:

--- Quote from: Grit Clef on September 24, 2024, 04:39:28 pm ---Oh, when I tried your command:
The result is, first 13571 came out and then an error:
Error: Process completed with exit code 141.

--- End quote ---

The method already works in my fork, see here:

my fork's main branch

ollydbg:

--- Quote from: ollydbg on September 24, 2024, 03:56:25 pm ---When I looked at the link

[MinGW] make check problem Issue #9115 protocolbuffers/protobuf

or

Make commands not working on Windows 10 at setting check up Issue #297 libcheck/check

It looks like the "DLL_EXPORT" is predefined in the auto configure tool?


EDIT:

I will try this patch below in the github action.


--- Code: ---diff --git a/src/include/cbplugin.h b/src/include/cbplugin.h
index 10258e5..a3ce67b 100644
--- a/src/include/cbplugin.h
+++ b/src/include/cbplugin.h
@@ -23,11 +23,11 @@
         #ifdef EXPORT_LIB
             #define PLUGIN_EXPORT __declspec (dllexport)
         #else // !EXPORT_LIB
-            #ifdef BUILDING_PLUGIN
+            #if defined(BUILDING_PLUGIN) || defined(DLL_EXPORT)
                 #define PLUGIN_EXPORT __declspec (dllexport)
-            #else // !BUILDING_PLUGIN
+            #else // !BUILDING_PLUGIN && !DLL_EXPORT
                 #define PLUGIN_EXPORT __declspec (dllimport)
-            #endif // BUILDING_PLUGIN
+            #endif // BUILDING_PLUGIN || DLL_EXPORT
         #endif // EXPORT_LIB
     #endif // PLUGIN_EXPORT
 #else

--- End code ---

--- End quote ---

Some good news, the above mentioned change works.  :)


Another issue/question is that why you need such patch:

https://github.com/asmwarrior/x86-codeblocks-builds/blob/main/0001-fix-32-bit-build-and-wxSmith.patch

?


I looked at this link:

https://github.com/msys2/MINGW-packages/tree/master/mingw-w64-codeblocks

I don't see they need such patch as yours.

ollydbg:
Well, I see your patch's content is too large, and I apply it locally, and I see only two line changes:

see below:


--- Code: ---diff --git a/src/plugins/contrib/wxSmith/Makefile.am b/src/plugins/contrib/wxSmith/Makefile.am
index 38262bf..dfe9df2 100644
--- a/src/plugins/contrib/wxSmith/Makefile.am
+++ b/src/plugins/contrib/wxSmith/Makefile.am
@@ -7,7 +7,7 @@ AM_CPPFLAGS = $(WX_CXXFLAGS) \
 
 lib_LTLIBRARIES = libwxsmithlib.la
 
-libwxsmithlib_la_LDFLAGS = -version-info 0:1:0 -shared
+libwxsmithlib_la_LDFLAGS = @MODULE_SHARED_LDFLAGS@ -version-info 0:1:0 -no-undefined -avoid-version
 
 libwxsmithlib_la_LIBADD = ../../../sdk/libcodeblocks.la \
  properties/libwxsmith_properties.la \


--- End code ---

I think this is exactly the patch file in msys2 here:

https://github.com/msys2/MINGW-packages/blob/f47229e160e1f31f24fdc6142be7b4df99b1a4c3/mingw-w64-codeblocks/001-makefile-wxsmith-add-no-undefined.patch

Another change line is here:


--- Code: ---diff --git a/src/src/Makefile.am b/src/src/Makefile.am
index 49d5dd9..d59889b 100644
--- a/src/src/Makefile.am
+++ b/src/src/Makefile.am
@@ -75,7 +75,7 @@ codeblocks_LDADD += resources.$(OBJEXT) -lexchndl -lcomctl32
 codeblocks_DEPENDENCIES = resources.$(OBJEXT)
 codeblocks_SOURCES += associations.cpp
 resources.$(OBJEXT): resources/resources.rc resources/amd64_dpi_aware_on.manifest
- $(WINDRES) $(WX_CXXFLAGS) -DcbDPI_AWARE_ON --include-dir $(top_srcdir)/src $< $@
+ $(WINDRES) $(WX_CPPFLAGS) -DcbDPI_AWARE_ON --include-dir $(top_srcdir)/src $< $@
 endif
 
 noinst_HEADERS = app.h \

--- End code ---

This is the command line option you changed for compiling the resource rc file. I don't see a similar patch in msys2's codeblocks folder:
https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-codeblocks

Another patch I see is here:
https://github.com/msys2/MINGW-packages/blob/f47229e160e1f31f24fdc6142be7b4df99b1a4c3/mingw-w64-codeblocks/005-codeblocks-plugin-fix.patch


--- Code: ------ a/src/sdk/configmanager.cpp (revision 13538)
+++ b/src/sdk/configmanager.cpp (working copy)
@@ -1497,7 +1497,7 @@
     if (plugin_path_global.IsEmpty())
     {
         if (platform::windows)
-            ConfigManager::plugin_path_global = app_path + _T("/../lib/codeblocks/plugins");
+            ConfigManager::plugin_path_global = app_path + _T("\\..\\lib\\codeblocks\\plugins");
         else if (platform::macosx)
             ConfigManager::plugin_path_global = data_path_global + _T("/plugins");
         else

--- End code ---

@Tim, can you say something about this code change? If we don't change this, what will happen? I don't see this code change in my github action's code.

Thanks.

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version