Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Guard needed in r13541

(1/2) > >>

Miguel Gimenez:
Revision r13541 added some wx3.2 font styles that are not present in wx3.0, but we still support 3.0 (at least on Linux). These values must be guarded with wxCHECK_VERSION(3, 1, 2) in wxssimplefonteditordlg.cpp:


--- Code: ---wxFONTWEIGHT_THIN
wxFONTWEIGHT_EXTRALIGHT
wxFONTWEIGHT_MEDIUM
wxFONTWEIGHT_SEMIBOLD
wxFONTWEIGHT_EXTRABOLD
wxFONTWEIGHT_HEAVY
wxFONTWEIGHT_EXTRAHEAVY
wxFONTWEIGHT_INVALID

--- End code ---

ollydbg:
Maybe Morten will do this?  :)

Miguel Gimenez:
Proposed patch attached

Wkerry:
Is there not a CI build that runs for Windows and Linux on any merge like bigger projects do? This would have detected this issue.

Another thing with big dev teams there is peer revies of code changes before they are merged into the trunk. Does this occur with CB? This may have picked it up depending on the reviewers skills.

Miguel Gimenez:
Sourceforge does not have these utilities, or at least I do not know about them. Peer reviewing is done sometimes for complex changes.

Navigation

[0] Message Index

[#] Next page

Go to full version