Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Show/hide tabs in message pane

(1/1)

sethjackson:
I have noticed a problem with this. When you hide a page in the message pane and the show it again the icon is not correct. It is just the generic one. Ex: the Debugger icon is a gear. Hide the Debugger tab, show it, and the icon is the default icon (pad of paper with a pencil).

mandrav:
This is a known issue. Hiding/showing message tabs is not yet 100% complete.

Der Meister:
Well, this patch should fix this issue:

--- Code: ---Index: src/sdk/messagemanager.cpp
===================================================================
--- src/sdk/messagemanager.cpp  (revision 2137)
+++ src/sdk/messagemanager.cpp  (working copy)
@@ -479,6 +479,7 @@
     {
         m_pNotebook->GetImageList()->push_back(bitmap);
         m_pNotebook->SetPageImageIndex(index, m_pNotebook->GetImageList()->size() - 1);
+        m_Logs[id]->bitmap = bitmap;
     }
 }

--- End code ---

I'm not sure if the copy of the bitmap gets destroyed as it should, but (during my little tests) at least the tabs got the correct icon after showing them again.

sethjackson:
 8) Hope it gets committed soon. :)

Navigation

[0] Message Index

Go to full version