« previous next »
Pages: 1 [2]  All   Go Down

Author Topic: RFC: DefaultWrite mode, CallTip, Completion popup fix  (Read 13429 times)

Offline Pecan

  • Plugin developer
  • Lives here!
  • ****
  • Posts: 2778
Re: RFC: DefaultWrite mode, CallTip, Completion popup fix
« Reply #15 on: July 30, 2023, 03:04:03 am »
Can anyone tell me if I need to change the sdk version when I apply this patch?

The patch adds a function declaration in platform.h and an implementation  in platWX.cpp.
« Last Edit: July 30, 2023, 03:48:55 am by Pecan »
Logged

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 5916
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Re: RFC: DefaultWrite mode, CallTip, Completion popup fix
« Reply #16 on: July 30, 2023, 09:53:30 am »
Quote from: Pecan on July 30, 2023, 03:04:03 am
Can anyone tell me if I need to change the sdk version when I apply this patch?

The patch adds a function declaration in platform.h and an implementation  in platWX.cpp.

From my point of view, you code change is inside the scintilla control, I think the interface(wxScintilla) is not changed. So no need to change the sdk version number.
Logged
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

Offline Pecan

  • Plugin developer
  • Lives here!
  • ****
  • Posts: 2778
Re: RFC: DefaultWrite mode, CallTip, Completion popup fix
« Reply #17 on: August 02, 2023, 06:57:03 pm »
Patch applied Head r13322.
Logged
Pages: 1 [2]  All   Go Up
« previous next »