Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development

GitBlocks to keep most of it working under Windows 10

(1/2) > >>

stahta01:
https://github.com/stahta01/GitBlocks

It builds and show status menu option works. Most of the other options have at least been partly tested.

If no project is open than using this plugin currently crashes the CB IDE.

Tim S.

stahta01:
Several commands were fixed for crashing if no projects are open
Edit Fixed attach and release in git repo; not yet done a release.
Edit2: Did an release
.
Tim S.

christo:
Hi Tim,

I tested the plugin in Linux wx3.0, it works fine. I've created pull request https://github.com/stahta01/GitBlocks/pull/1 with project file. Could you please check?

Thanks,
Christo

stahta01:

--- Quote from: christo on September 15, 2023, 06:04:23 pm ---Hi Tim,

I tested the plugin in Linux wx3.0, it works fine. I've created pull request https://github.com/stahta01/GitBlocks/pull/1 with project file. Could you please check?

Thanks,
Christo

--- End quote ---

This is the first time for me to process an PR; I think I did it right.

Tim S

sodev:
Uhm, well... not really :P.

The history looks like you cherry-picked the commit, that was the worst option (does the GitHub UI even offer that option?). In general you perform a merge, for external contributions i prefer to always enforce a merge, even if like in this case a fast-forward merge would have been possible.

Also, it is kind of bad practice to create a PR from the main branch, in general you make a feature branch and create a PR from that one.

Navigation

[0] Message Index

[#] Next page