Author Topic: remove the borland macro in our source files  (Read 852 times)

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 5783
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
remove the borland macro in our source files
« on: January 09, 2023, 09:05:57 am »
Hi, I think those code snippet:

Code
#ifdef __BORLANDC__
#pragma hdrstop
#endif

should be removed from all our source code, any ideas?

Thanks.
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

Offline Miguel Gimenez

  • Developer
  • Lives here!
  • *****
  • Posts: 1363
Re: remove the borland macro in our source files
« Reply #1 on: January 09, 2023, 07:10:52 pm »
wxWidgets has removed support for Borland, so IMHO keeping it in the codebase has little sense.

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 5783
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Re: remove the borland macro in our source files
« Reply #2 on: January 10, 2023, 03:44:31 am »
Thanks.
Agree.
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

Offline Pecan

  • Plugin developer
  • Lives here!
  • ****
  • Posts: 2569
Re: remove the borland macro in our source files
« Reply #3 on: January 10, 2023, 06:32:25 am »
I also agree. Time to trim the grass.
I always delete it anyway.

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 5783
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Re: remove the borland macro in our source files
« Reply #4 on: February 01, 2023, 04:34:53 am »
It is done in the trunk now.  ;)
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.