Author Topic: images in FortranProject plugins  (Read 5256 times)

Offline gd_on

  • Lives here!
  • ****
  • Posts: 796
images in FortranProject plugins
« on: October 10, 2022, 12:11:30 pm »
Some questions/remarks about FortranProject plugin, and more specialy images in it.

When installing this plugin, official nightly or my own builds, I see that some images are installed several times :
Inside \share\CodeBlocks\images there is a fortranproject subfolder. Inside \share\CodeBlocks\FortranProject.zip there is also an images\fortranproject subfolder which contains exacly the same images subfolders and files. Are they both useful ?
More, in the 16x16 subfolder there are 46 files, but in all other (20x20, 24x24 ...) there are 47 files : fprojectmakevisible.png is missing in the 16 pixels subfolder. But may be, as other fproject*.png, which are present in the zip (at two different places : in the root 16x16, ... and inside fortranproject\16x16, ...), they are declared more than necessary.
Apparently, this does not affect the functionality of the plugin, but may be a small cleaning could be nice.
This remark is also true for last introduced svg images.

Another small annoying thing :
in Fortranproject.cpp, line 544, the submenu label is _("Jump last"). But in fortranprojecttoolbar.xrc, lines 10 and 11, labels are "Last jump".
Not the same label, but the same function in menus, tooltips,... I think, it should be the same. Which one is the best ? Especialy when translating in an other langage, the order of the words can have a totally different meaning.

gd_on
Windows 11 64 bits (23H2), svn C::B (last version or almost!), wxWidgets 3.2.4 (tests with 3.3), Msys2 Compilers 13.2.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\msys64\mingw64) or 32 bits (dwarf2, posix  in C:\msys64\mingw32).

Offline Miguel Gimenez

  • Developer
  • Lives here!
  • *****
  • Posts: 1553
Re: images in FortranProject plugins
« Reply #1 on: October 10, 2022, 12:29:38 pm »
I know there were some discussion between Darmar and Obfuscated about this and the update scripts, IIRC the duplicated images are used outside C::B.

Relating the text mismatch,  I do not use FortranProject: Which one is correct?

Offline gd_on

  • Lives here!
  • ****
  • Posts: 796
Re: images in FortranProject plugins
« Reply #2 on: October 10, 2022, 02:26:10 pm »
I think that somebody whose native langage is English should answer. I prefer "Last jump", but I'm french (nobody's perfect  ;D)
Windows 11 64 bits (23H2), svn C::B (last version or almost!), wxWidgets 3.2.4 (tests with 3.3), Msys2 Compilers 13.2.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\msys64\mingw64) or 32 bits (dwarf2, posix  in C:\msys64\mingw32).

Offline Miguel Gimenez

  • Developer
  • Lives here!
  • *****
  • Posts: 1553
Re: images in FortranProject plugins
« Reply #3 on: October 10, 2022, 02:52:26 pm »
The icon name (fprojectjumphome) and the associated method (OnJumpHome()) suggest "Jump home", but I do not know if this has any sense.

Offline Miguel Gimenez

  • Developer
  • Lives here!
  • *****
  • Posts: 1553
Re: images in FortranProject plugins
« Reply #4 on: October 11, 2022, 11:36:29 am »
I have just changed the toolbar text so it matches the menu.

Offline gd_on

  • Lives here!
  • ****
  • Posts: 796
Re: images in FortranProject plugins
« Reply #5 on: October 11, 2022, 12:46:50 pm »
Thanks.
May be Darmar could have an advice for the best label. Effectively the "home" in icon name suggest something else !
Windows 11 64 bits (23H2), svn C::B (last version or almost!), wxWidgets 3.2.4 (tests with 3.3), Msys2 Compilers 13.2.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\msys64\mingw64) or 32 bits (dwarf2, posix  in C:\msys64\mingw32).