Author Topic: New Variable to support wx-config in MSys2 MinGW  (Read 1543 times)

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 5524
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Re: New Variable to support wx-config in MSys2 MinGW
« Reply #15 on: May 19, 2022, 04:28:23 pm »

I think I have gotten the wxWidgets 3.1.6 PR to MSys2 MinGW done...

Do you have the direct2D enabled wx 3.1.6 for your PR?
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

Offline stahta01

  • Lives here!
  • ****
  • Posts: 7271
    • My Best Post
Re: New Variable to support wx-config in MSys2 MinGW
« Reply #16 on: May 19, 2022, 04:50:14 pm »

I think I have gotten the wxWidgets 3.1.6 PR to MSys2 MinGW done...

Do you have the direct2D enabled wx 3.1.6 for your PR?

Yep, that was one of the changes I added after the first time I did the PR.
https://github.com/msys2/MINGW-packages/pull/11631

Quote
Summary of the current changes

wxWidgets3.1: Update to version 3.1.6; and,

Removed MSYSTEM guard in "wx-config.in".
Redo manifest filename logic in "wx/msw/wx.rc".
The prior manifest logic failed to work under Clang64.
Add replaces "wxmsw3.1-git" package.
Add "enable-graphics-d2d" to help support Code::Blocks IDE.

Tim S.
C Programmer working to learn more about C++ and Git.
On Windows 7 64 bit and Windows 10 32 bit.
On Debian Stretch, compiling CB Trunk against wxWidgets 3.0.
--
When in doubt, read the CB WiKi FAQ. http://wiki.codeblocks.org

Offline PB

  • Multiple posting newcomer
  • *
  • Posts: 31
Re: New Variable to support wx-config in MSys2 MinGW
« Reply #17 on: May 20, 2022, 11:52:17 pm »

Summary of the current changes
Redo manifest filename logic in "wx/msw/wx.rc".
The prior manifest logic failed to work under Clang64.

I know virtually nothing about MSYS2 packages but I wonder why are those changes necessary?

I have tried not that long ago and wxWidgets with the unmodified wx.rc builds just fine not only with GCC (package mingw-w64-x86_64-toolchain) but also clang (package mingw-w64-clang-x86_64-toolchain)?

Is there another clang package? I admit I have no idea if that package i listed uses its own resource compiler (llvm-rc) or mingw one (windres).
« Last Edit: May 20, 2022, 11:57:07 pm by PB »

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 5524
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Re: New Variable to support wx-config in MSys2 MinGW
« Reply #18 on: May 21, 2022, 05:20:03 am »
Hi, tim, I add this macro in rev12816. Thanks!
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

Offline stahta01

  • Lives here!
  • ****
  • Posts: 7271
    • My Best Post
Re: New Variable to support wx-config in MSys2 MinGW
« Reply #19 on: May 22, 2022, 05:20:05 pm »

Summary of the current changes
Redo manifest filename logic in "wx/msw/wx.rc".
The prior manifest logic failed to work under Clang64.

I know virtually nothing about MSYS2 packages but I wonder why are those changes necessary?

I have tried not that long ago and wxWidgets with the unmodified wx.rc builds just fine not only with GCC (package mingw-w64-x86_64-toolchain) but also clang (package mingw-w64-clang-x86_64-toolchain)?

Is there another clang package? I admit I have no idea if that package i listed uses its own resource compiler (llvm-rc) or mingw one (windres).

The library builds without the change; but, some sample(s) will error without the change!
Edit: The UCRT64 use its own resource compiler (llvm-rc)

Tim S.
« Last Edit: May 22, 2022, 05:29:32 pm by stahta01 »
C Programmer working to learn more about C++ and Git.
On Windows 7 64 bit and Windows 10 32 bit.
On Debian Stretch, compiling CB Trunk against wxWidgets 3.0.
--
When in doubt, read the CB WiKi FAQ. http://wiki.codeblocks.org