Author Topic: The 16 Januari 2022 build (12655) is out.  (Read 9175 times)

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5370
The 16 Januari 2022 build (12655) is out.
« on: January 16, 2022, 10:57:36 am »
We switched to wx 3.1.5 --> download the new wx dll's see link below

Get quick announcements through the RSS feed http://www.codeblocks.org/nightly/CodeBlock_RSS.xml

Before you use a nightly make sure you understand how it works.

A link to the unicode windows wxWidget dll(s) for Code::Blocks : https://sourceforge.net/projects/codeblocks/files/Binaries/Nightlies/Prerequisites/wxmsw31u_gcc_cb_wx315_2D_gcc810-mingw64.7z
A link to Mingw64 dll's needed by Code::Blocks : http://sourceforge.net/projects/codeblocks/files/Binaries/Nightlies/Prerequisites/Mingw64dlls8.1.0.7z


The 16 Januari 2022 build is out.
  - Windows :
   http://sourceforge.net/projects/codeblocks/files/Binaries/Nightlies/2022/CB_20220116_rev12655_win64.7z
  - Linux :
   none

The current SDK version is : 2.16.0

Resolved Fixed:

  • Sort compiler list in compiler detection dialog.
  • Compiler: Use the same shell for cleaning and compiling makefiles (ticket #389
  • wxSmith: Fix compilation when wxUSE_STL=1 (ticket #873)
  • Allow removal from project of multiple selected files (ticket #116)
  • Add Jens Lody's DisplayEvent core plugin. (WIP)

Regressions/Confirmed/Annoying/Common bugs:



    Offline AndrewCot

    • Plugin developer
    • Lives here!
    • ****
    • Posts: 654
    Re: The 16 Januari 2022 build (12655) is out.
    « Reply #1 on: January 16, 2022, 12:09:57 pm »
    Jens Lody's DisplayEvent core plugin is as expected not in the 7z file as it it not built by default in SVN 12655.

    Offline Xaviou

    • Regular
    • ***
    • Posts: 356
      • X@v's wxStuff
    Re: The 16 Januari 2022 build (12655) is out.
    « Reply #2 on: January 20, 2022, 09:10:20 pm »
    Hi

    OS X version of this rev (12596) can be downloaded from my Google Drive.
    There is a specific dmg file for versions 10.15 and 11.6 of the OS.
    Note that these are not notarized versions of the application.

    32 bits version for Windows can also be found in the same place.

    Debian Buster and Bullseye (32 and 64 bits) can be installed from my repo.

    The problem I talked about in my 9 january's post is still here.
    I comes from the rev12597 modifications (this has been confirmed by the fact that disabling the "Forein Project Importer" plugin allows Code::Blocks to run correctly.
    The problem is the last loop of the modified code :
    Code
    wxMenuItemList m_List = m_Menu->GetMenuItems();
        for (wxMenuItemList::iterator it = m_List.begin(); it != m_List.end(); ++it)
            importSubMenu->Append(*it);
    The "GetMenuItems" call doesn't detach the menu entries of m_Menu so adding them "as is" to the newly created sub menu is not a good thing (but perhaps am I missing something...)
    However, doing something like the following works fine:
    Code
    wxMenuItemList m_List = m_Menu->GetMenuItems();
    wxMenuItem *item;
        for (wxMenuItemList::iterator it = m_List.begin(); it != m_List.end(); ++it)
        {
            item = *it;
            importSubMenu->Append(item->GetId(), item->GetItemLabel);
        }
    But in this case, the content of m_Menu seems to never been destroyed.

    Regards
    Xav'
    The french wxWidgets site : http://www.wxdev.fr
    My wxWidgets's stuff : https://wxstuff.xaviou.fr/

    Offline Miguel Gimenez

    • Developer
    • Lives here!
    • *****
    • Posts: 1113
    Re: The 16 Januari 2022 build (12655) is out.
    « Reply #3 on: January 20, 2022, 09:33:29 pm »
     I will check, thank you.

    Offline Xaviou

    • Regular
    • ***
    • Posts: 356
      • X@v's wxStuff
    Re: The 16 Januari 2022 build (12655) is out.
    « Reply #4 on: January 20, 2022, 10:21:33 pm »
    Hi
    I will check, thank you.
    Thank you.

    As a complement : the official wxWidgets doc related to wxMenu::Append(wxMenuItem *menuItem) confirm that the item added using this method will be owned by the menu to witch they are added.

    Regards
    Xav'
    The french wxWidgets site : http://www.wxdev.fr
    My wxWidgets's stuff : https://wxstuff.xaviou.fr/

    Offline Miguel Gimenez

    • Developer
    • Lives here!
    • *****
    • Posts: 1113
    Re: The 16 Januari 2022 build (12655) is out.
    « Reply #5 on: January 20, 2022, 11:29:30 pm »
    Can you check if this works?
    Code
        for (wxMenuItemList::iterator it = m_List.begin(); it != m_List.end(); ++it)
            importSubMenu->Append(m_Menu->Remove(*it));
    TIA

    Offline Xaviou

    • Regular
    • ***
    • Posts: 356
      • X@v's wxStuff
    Re: The 16 Januari 2022 build (12655) is out.
    « Reply #6 on: January 21, 2022, 07:29:55 am »
    Hi
    Can you check if this works?
    Code
        for (wxMenuItemList::iterator it = m_List.begin(); it != m_List.end(); ++it)
            importSubMenu->Append(m_Menu->Remove(*it));
    TIA
    It does : Nice.
    Don't forget to destroy the menu itself (m_Menu) because it is never done.

    Thank you.

    Regards
    Xav'
    The french wxWidgets site : http://www.wxdev.fr
    My wxWidgets's stuff : https://wxstuff.xaviou.fr/

    Offline Miguel Gimenez

    • Developer
    • Lives here!
    • *****
    • Posts: 1113
    Re: The 16 Januari 2022 build (12655) is out.
    « Reply #7 on: January 21, 2022, 10:12:48 am »
    I attached only the relevant part of the patch, the complete version changes m_Menu from private member to local variable and deletes it when not needed.

    Thank you for testing.

    BTW, there was an issue with some wxChoice not showing on toolbars on MAC (the target selection choice, for example). I made a commit fixing this on Ubuntu, can you check if it fixes the problem on MAC?

    Offline AndrewCot

    • Plugin developer
    • Lives here!
    • ****
    • Posts: 654
    Re: The 16 Januari 2022 build (12655) is out.
    « Reply #8 on: January 21, 2022, 12:35:13 pm »
    @Miguel The SVN https://sourceforge.net/p/codeblocks/code/12666/ changes do not "delete menu;" on any of the returns between the menu create and the delete you added. More changes are required.

    @ALL
    I suggest creating tickets and getting the patches reviewed before being applied so the changes can be tracked and reviews done to stop code going onto the trunk that has at least been code reviewed (or had a chance of being reviewed in that if it does not get reviewed with X days then it probably should be deemed to be okay. X IMHO X should be a between 2 and 4 inclusive, but varies around Chrissy and Easter as these are usually holiday periods in large parts of the world with the other holiday periods dependent on the country).

    Offline Xaviou

    • Regular
    • ***
    • Posts: 356
      • X@v's wxStuff
    Re: The 16 Januari 2022 build (12655) is out.
    « Reply #9 on: January 21, 2022, 12:41:03 pm »
    Hi

    I attached only the relevant part of the patch, the complete version changes m_Menu from private member to local variable and deletes it when not needed.

    Thank you for testing.

    BTW, there was an issue with some wxChoice not showing on toolbars on MAC (the target selection choice, for example). I made a commit fixing this on Ubuntu, can you check if it fixes the problem on MAC?

    Can't build the last revision : rev 12660 broke the build process.
    I've attached the output (and errors) to this post.

    Regards
    Xav'
    The french wxWidgets site : http://www.wxdev.fr
    My wxWidgets's stuff : https://wxstuff.xaviou.fr/

    Offline Miguel Gimenez

    • Developer
    • Lives here!
    • *****
    • Posts: 1113
    Re: The 16 Januari 2022 build (12655) is out.
    « Reply #10 on: January 21, 2022, 01:50:59 pm »
    @andrewcot, thank you for pointing this out. This is one of the reasons I dislike multiple return points.

    Offline BlueHazzard

    • Developer
    • Lives here!
    • *****
    • Posts: 3255
    Re: The 16 Januari 2022 build (12655) is out.
    « Reply #11 on: January 21, 2022, 02:08:40 pm »
    Hi

    I attached only the relevant part of the patch, the complete version changes m_Menu from private member to local variable and deletes it when not needed.

    Thank you for testing.

    BTW, there was an issue with some wxChoice not showing on toolbars on MAC (the target selection choice, for example). I made a commit fixing this on Ubuntu, can you check if it fixes the problem on MAC?

    Can't build the last revision : rev 12660 broke the build process.
    I've attached the output (and errors) to this post.

    Regards
    Xav'
    O s**t... i will look into it...
    Is this on OSX?

    Can you test drag and drop for me if the build works? I have no mac to test this, and i have the worry that DnD does not work on wxCocca

    Offline BlueHazzard

    • Developer
    • Lives here!
    • *****
    • Posts: 3255
    Re: The 16 Januari 2022 build (12655) is out.
    « Reply #12 on: January 21, 2022, 02:28:50 pm »
    @Xaviou
    Can you add
    Code
    #include <wx/dataobj.h>

    to src/projectmanagerui.h:12 ?

    That should clear most error messages?
    I compiled this on linux and windows and did not get any error message...

    Offline Xaviou

    • Regular
    • ***
    • Posts: 356
      • X@v's wxStuff
    Re: The 16 Januari 2022 build (12655) is out.
    « Reply #13 on: January 21, 2022, 03:13:44 pm »
    @Xaviou
    Can you add
    Code
    #include <wx/dataobj.h>

    to src/projectmanagerui.h:12 ?

    That should clear most error messages?
    I compiled this on linux and windows and did not get any error message...
    Tested : it is not enough.
    Errors have decreased from 18 to 11 but build is still broken.
    I've attached the last build log

    Regards
    Xav'
    The french wxWidgets site : http://www.wxdev.fr
    My wxWidgets's stuff : https://wxstuff.xaviou.fr/

    Offline BlueHazzard

    • Developer
    • Lives here!
    • *****
    • Posts: 3255
    Re: The 16 Januari 2022 build (12655) is out.
    « Reply #14 on: January 21, 2022, 03:43:07 pm »
    Thank you for testing...

    Code
    #include <wx/dataobj.h>
    #include <wx/dnd.h>
    #include <wx/dataobj.h>

    what about this in src/projectmanagerui.h:12 ?

    i looked into it and it seems that building for macos without buying an mac is impossible...
    what a shame waled garden...