Author Topic: svn-12539  (Read 8272 times)

Offline LETARTARE

  • Lives here!
  • ****
  • Posts: 531
  • L'ami de l'homme.The friend of man.
    • LETARTARE
svn-12539
« on: December 01, 2021, 04:44:47 pm »
svn-12539 :: in plugin contrib 'BrowseTracker_wx30-unix.cbp', the definition of 'cbDEBUG' is missing !!, which causes the non-recognition of 'cbAssertNonFatal()'
CB-13483, plugins-sdk-2.25.0 : Collector-2.0.0, AddOnForQt-3.9.1
1-Win7 Business Pack1 64bits : wx-3.2.4, gcc-8.1.0,
2-OpenSuse::Leap-15.4-64bits : wx-3.2.4;gtk3, gcc-8.2.1,
=> !! The messages are translated by Deepl

Offline Pecan

  • Plugin developer
  • Lives here!
  • ****
  • Posts: 2743
Re: svn-12539
« Reply #1 on: December 02, 2021, 08:08:32 am »
Thanks. Fixed in head r12543

Offline blauzahn

  • Almost regular
  • **
  • Posts: 153
Re: svn-12539
« Reply #2 on: December 07, 2021, 01:23:54 pm »
Hello,

I see the same compile error with svn-12556. Here I use ubuntu-20.04 as well as arch linux and
compile cb as usual per command-line, configure and make.

Although the symbol cbDEBUG might be missing in some project(s), IMHO
cbAssertNonFatal should be handled in file src/include/cbexception.h in the same way cbAssert is.

mainly:
Code
#ifndef cbDEBUG
    #define cbAssertMessage(expr)
    #define cbAssertNonFatal(expr)
    #define cbAssert(expr)
 #else

Or maybe define them like en.cppreference.com/w/cpp/error/assert.

A patch for the file is attached.

Thanks in advance.


Offline Totoxa

  • Multiple posting newcomer
  • *
  • Posts: 32
Re: svn-12539
« Reply #3 on: December 09, 2021, 01:33:50 am »
Thanks. Fixed in head r12543

That fix doesn't work for building from command line (bootstrap, configure, make).

Offline Pecan

  • Plugin developer
  • Lives here!
  • ****
  • Posts: 2743
Re: svn-12539
« Reply #4 on: December 09, 2021, 07:06:04 pm »
... IMHO cbAssertNonFatal should be handled in file src/include/cbexception.h in the same way cbAssert is.
mainly:
Code
#ifndef cbDEBUG
    #define cbAssertMessage(expr)
    #define cbAssertNonFatal(expr)
    #define cbAssert(expr)
 #else

Thanks, fixed again, Head r12566