Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development

FileManager Plugin wx3.1.x (64 bit) upgrade by omlk

<< < (2/4) > >>

Miguel Gimenez:
You should post a proper patch, not the whole folder content. In fact, File Manager has changed since 12295 (see commits 12312, 12318 and 12319), so replacing the files is not possible.

omlk:

--- Quote from: Miguel Gimenez on May 05, 2021, 05:00:55 pm ---You should post a proper patch, not the whole folder content. In fact, File Manager has changed since 12295 (see commits 12312, 12318 and 12319), so replacing the files is not possible.

--- End quote ---
I svn up to 12295(with merge) and many more edits in codeblocks project, so I don't know how to make a patch for one plugin folder, if someone gives an example of how to do it, then I'll try and where to send this patch?
If I could create a new svn brunch for omlk repository, I would post changes there, but I don't have access. 

Also I think my code is much better than edits in commit: 12312, 12318 and 12319

oBFusCATed:
Here is an explanation how to make patches from svn: https://wiki.codeblocks.org/index.php/Creating_a_patch_to_submit_(Patch_Tracker)
You cannot make branches in svn, because you're not developer and branches in svn are heavy.
You can use git to do it (if you're more familiar with git) and base your branch on the master branch in https://github.com/obfuscated/codeblocks_sf

Edit: Just a hint for better success: If you can post a patch per fix it will ease the review process.

omlk:

--- Quote from: oBFusCATed on May 05, 2021, 10:07:54 pm ---Here is an explanation how to make patches from svn: https://wiki.codeblocks.org/index.php/Creating_a_patch_to_submit_(Patch_Tracker)
You cannot make branches in svn, because you're not developer and branches in svn are heavy.
You can use git to do it (if you're more familiar with git) and base your branch on the master branch in https://github.com/obfuscated/codeblocks_sf
Edit: Just a hint for better success: If you can post a patch per fix it will ease the review process.

--- End quote ---

* Any ideas on how to fix this for a large number of files?
* https://lookfirst.com/2008/11/subversion-inconsistent-line-ending.html
* dos2unix or unix2dos or another ways

--- Code: ---$ svn diff -r PREV --summarize > omlk_12295.path
svn: E135000: File '/h/i/CB_src/s_merge - my12295/trunk/src/plugins/codecompletion/parser/cclogger.h' has inconsistent newlines
svn: E135000: Inconsistent line ending style
svn: E200042: Additional errors:
svn: E135000: Inconsistent line ending style

--- End code ---

--- Code: ---$ svn diff -x '-b --ignore-eol-style' -r PREV --summarize > omlk_12295.path
svn: E135000: File '/h/i/CB_src/s_merge - my12295/trunk/src/plugins/codecompletion/parser/cclogger.h' has inconsistent newlines
svn: E135000: Inconsistent line ending style
svn: E200042: Additional errors:
svn: E135000: Inconsistent line ending style

--- End code ---

Miguel Gimenez:

--- Quote ---Any ideas on how to fix this for a large number of files?
--- End quote ---

unix2dos * will do it in the current folder, if you need to change subfolders use find . -type f -print0 | xargs -0 unix2dos. Be careful, some files use Unix EOL.

You can generate a patch just using


--- Code: ---svn diff > omlk_12295.patch
--- End code ---

unless you really need the reverse patch

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version