Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development
FileManager Plugin wx3.1.x (64 bit) upgrade by omlk
omlk:
--- Code: ---$ svn diff -x '-b --ignore-eol-style' ./src/plugins/contrib/FileManager/ > omlk_12295_FileManager_rev0.3.path
--- End code ---
File attached to this post.
oBFusCATed:
Interesting:
1. wild reformatting changes for no apparent reason, uses tabs instead of spaces
2. switches to c++20, but still uses goto
3. fails to apply cleanly on latest trunk/master:
--- Code: ---> patch -p0 < /tmp/omlk_12295_FileManager_rev0.3.path
patching file src/plugins/contrib/FileManager/FileExplorer.cpp
Hunk #34 FAILED at 762.
Hunk #52 succeeded at 1295 with fuzz 2.
Hunk #53 succeeded at 1305 (offset 1 line).
Hunk #54 FAILED at 1329.
Hunk #55 succeeded at 1366 (offset 3 lines).
Hunk #56 succeeded at 1385 (offset 3 lines).
Hunk #57 FAILED at 1395.
Hunk #58 FAILED at 1512.
4 out of 58 hunks FAILED -- saving rejects to file src/plugins/contrib/FileManager/FileExplorer.cpp.rej
patching file src/plugins/contrib/FileManager/FileExplorer.h
patching file src/plugins/contrib/FileManager/FileManager_wx31_64.cbp
patching file src/plugins/contrib/FileManager/se_globals.cpp
patching file src/plugins/contrib/FileManager/se_globals.h
--- End code ---
This would be rough...
omlk:
* I don't understand what's wrong with the patch yet? The patch should be set to r12295.
* What's wrong with goto?I attached new patch include fixes from r12319, r12318
oBFusCATed:
--- Quote from: omlk on May 07, 2021, 01:21:52 pm ---I don't understand what's wrong with the patch yet? The patch should be set to r12295.
--- End quote ---
What do you mean by "set to r12295". The idea is to update to the latest trunk commit, make your changes and then create the patch.
If you're more comfortable with git you can use https://github.com/obfuscated/codeblocks_sf
--- Quote from: omlk on May 07, 2021, 01:21:52 pm ---What's wrong with goto?
--- End quote ---
https://homepages.cwi.nl/~storm/teaching/reader/Dijkstra68.pdf
Commaster:
(Offtopic) Also it's patch, not path: https://en.wikipedia.org/wiki/Patch_(computing)
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version