Author Topic: FileManager Plugin wx3.1.x (64 bit) upgrade by omlk  (Read 1258 times)

Offline omlk

  • Multiple posting newcomer
  • *
  • Posts: 48
FileManager Plugin wx3.1.x (64 bit) upgrade by omlk
« on: December 23, 2020, 11:26:48 am »
If need  ;) I attach files for FileManager Plugin wx3.1.x (64 bit) with my upgrade:
  • fix if drag items is null
  • fix event on key Del press
  • add checks when drag files: move or copy with prevent replace
  • add checks when click move or copy from context menu with prevent replace
« Last Edit: Yesterday at 02:17:07 am by omlk »

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13194
    • Travis build status
Re: FileManager Plugin wx3.1.x (64 bit) upgrade by omlk
« Reply #1 on: December 23, 2020, 12:01:54 pm »
I know you don't want to read much or cooperate with us, but if you decide to change your mind sometime in the future you could check this link: http://wiki.codeblocks.org/index.php/Creating_a_patch_to_submit_(Patch_Tracker)
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline omlk

  • Multiple posting newcomer
  • *
  • Posts: 48
Re: FileManager Plugin wx3.1.x (64 bit) upgrade by omlk
« Reply #2 on: December 23, 2020, 12:39:01 pm »

Offline omlk

  • Multiple posting newcomer
  • *
  • Posts: 48
Re: FileManager Plugin wx3.1.x (64 bit) upgrade by omlk
« Reply #3 on: December 23, 2020, 12:41:23 pm »
I know you don't want to read much or cooperate with us, but if you decide to change your mind sometime in the future you could check this link: http://wiki.codeblocks.org/index.php/Creating_a_patch_to_submit_(Patch_Tracker)
Okay, I'll read how to make patches.  :)

Offline omlk

  • Multiple posting newcomer
  • *
  • Posts: 48
Re: FileManager Plugin wx3.1.x (64 bit) upgrade by omlk
« Reply #4 on: Yesterday at 01:52:15 am »
FileManager Plugin wx3.1.x (64 bit) with my upgrade: svn 12295
  • Add: fast button clear masks
  • Fixed: collapse and expand items, cursor icons
  • More: many fixes and edits to improve the code and performance of the plugin
« Last Edit: Yesterday at 02:13:59 am by omlk »

Offline Miguel Gimenez

  • Lives here!
  • ****
  • Posts: 690
Re: FileManager Plugin wx3.1.x (64 bit) upgrade by omlk
« Reply #5 on: Yesterday at 05:00:55 pm »
You should post a proper patch, not the whole folder content. In fact, File Manager has changed since 12295 (see commits 12312, 12318 and 12319), so replacing the files is not possible.

Offline omlk

  • Multiple posting newcomer
  • *
  • Posts: 48
Re: FileManager Plugin wx3.1.x (64 bit) upgrade by omlk
« Reply #6 on: Yesterday at 07:56:49 pm »
You should post a proper patch, not the whole folder content. In fact, File Manager has changed since 12295 (see commits 12312, 12318 and 12319), so replacing the files is not possible.
I svn up to 12295(with merge) and many more edits in codeblocks project, so I don't know how to make a patch for one plugin folder, if someone gives an example of how to do it, then I'll try and where to send this patch?
If I could create a new svn brunch for omlk repository, I would post changes there, but I don't have access. 

Also I think my code is much better than edits in commit: 12312, 12318 and 12319
« Last Edit: Today at 06:40:32 am by omlk »

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13194
    • Travis build status
Re: FileManager Plugin wx3.1.x (64 bit) upgrade by omlk
« Reply #7 on: Yesterday at 10:07:54 pm »
Here is an explanation how to make patches from svn: https://wiki.codeblocks.org/index.php/Creating_a_patch_to_submit_(Patch_Tracker)
You cannot make branches in svn, because you're not developer and branches in svn are heavy.
You can use git to do it (if you're more familiar with git) and base your branch on the master branch in https://github.com/obfuscated/codeblocks_sf

Edit: Just a hint for better success: If you can post a patch per fix it will ease the review process.
« Last Edit: Yesterday at 10:10:00 pm by oBFusCATed »
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline omlk

  • Multiple posting newcomer
  • *
  • Posts: 48
Re: FileManager Plugin wx3.1.x (64 bit) upgrade by omlk
« Reply #8 on: Today at 06:33:39 am »
Here is an explanation how to make patches from svn: https://wiki.codeblocks.org/index.php/Creating_a_patch_to_submit_(Patch_Tracker)
You cannot make branches in svn, because you're not developer and branches in svn are heavy.
You can use git to do it (if you're more familiar with git) and base your branch on the master branch in https://github.com/obfuscated/codeblocks_sf
Edit: Just a hint for better success: If you can post a patch per fix it will ease the review process.
Code
$ svn diff -r PREV --summarize > omlk_12295.path
svn: E135000: File '/h/i/CB_src/s_merge - my12295/trunk/src/plugins/codecompletion/parser/cclogger.h' has inconsistent newlines
svn: E135000: Inconsistent line ending style
svn: E200042: Additional errors:
svn: E135000: Inconsistent line ending style
Code
$ svn diff -x '-b --ignore-eol-style' -r PREV --summarize > omlk_12295.path
svn: E135000: File '/h/i/CB_src/s_merge - my12295/trunk/src/plugins/codecompletion/parser/cclogger.h' has inconsistent newlines
svn: E135000: Inconsistent line ending style
svn: E200042: Additional errors:
svn: E135000: Inconsistent line ending style

Offline Miguel Gimenez

  • Lives here!
  • ****
  • Posts: 690
Re: FileManager Plugin wx3.1.x (64 bit) upgrade by omlk
« Reply #9 on: Today at 09:35:34 am »
Quote
Any ideas on how to fix this for a large number of files?

unix2dos * will do it in the current folder, if you need to change subfolders use find . -type f -print0 | xargs -0 unix2dos. Be careful, some files use Unix EOL.

You can generate a patch just using

Code
svn diff > omlk_12295.patch

unless you really need the reverse patch