Edit shortcuts stopped working !

[gul]

Hello everyone,


First of all, since this my first post here, I would like to thank everyone involved for making sure CB is as good as it is. I've been using it for about 8 years on various systems and I had no absolutely issues until now.

Anyway I haven't used CB in about last two months but today I wanted to test out some code I typed previously in plain text editor. When I tried to paste the code using CTRL-V nothing happened, so i tried with rightclick menu - that worked.
 
I restarted both CB and my machine - that did not fix the problem. After that I installed the latest version (20.3) and moved the config folder but that also did not help.

Upon further investigation i discovered that CTRL-C, CTRL-V, CTRL-X and CTRL-A (copy,paste,cut,select all) shortcuts stopped working in CB.

Also i cant change ANY keyboard shortcuts in settings, nothing happens when i press CTRL-* it doesn't register the other key, just CTRL (* is any latter, for some reason numbers and some chars do work)

Interesting thing is that all the shortcuts that do not work are NOT listed in keybind config files (for e.g. CTRL-S saves the file correctly as it should.)
I suppose they are managed by the OS and that's most probably where the problem is but i don't have the knowledge to solve it.

I'm running CB20.3 on Linux Mint 19.3 Cinnamon, the problem occurs only in CB so far.

This is one of the strangest software behaviors I saw, so any help would be appreciated.


Thanks in advance and stay safe.

[stahta01]

IIRC, the mouse sap plugin might be a possible cause. You could try turning it off.

Also, you might mention the desktop software being used; I have no idea what desktop Cinnamon uses.
I would also mention the wxGTK version information.

Edit: I just found out that Cinnamon is a desktop.

Tim S.

[gul]

Hey thanks for the quick reply,

I just tried to disable mouse sap plugin, that did not solve the problem.

I'm relatively new to linux, so I'm not exactly sure what do you mean, afaik Cinnamon is the desktop software?

Also i'm not sure how to find the wxGTK version?

[stahta01]

Code::Blocks option:
Help -> About
Tab: Information.

I get this about wxWidgets

wxWidgets Library (wxMSW port)
Version 3.1.3 (Unicode: wchar_t, debug level: 1),
compiled at Nov  1 2019 18:53:26

I missed this part of the information.

Runtime version of toolkit used is 6.1.

Tim S.

[gul]

Code

Name             : Code::Blocks
Version          : 20.03-r11983
SDK Version      : 2.0.0
Scintilla Version: 3.7.5
Author           : The Code::Blocks Team
E-mail           : info@codeblocks.org
Website          : http://www.codeblocks.org

wxWidgets Library (wxGTK port)
Version 3.0.4 (Unicode: wchar_t, debug level: 1),
Runtime version of toolkit used is 2.24.
Compile-time GTK+ version is 2.24.32.

[stahta01]

Thank you for the information; that should hopefully be enough for an Linux person to figure out the problem.

Tim S.

[oBFusCATed]

Does copy/paste using the menu items work?
What happens if you delete the keybinder config? Or if you disable the plugin?
There were several problems with the plugin which have been fixed, but unfortunately 20.03 didn't get all the fixes.

[gul]

Hello,

Copy,paste etc using menu does work.
I already tried to delete codeblocks config folder alltogether that didn't help, if that's what you mean.
When this problem appeared i didn't even had the keyboard shortcuts plugin installed, i installed contrib package later in an effort to fix the problem.
Besides there are NO keybinds for copy,paste,cut, and selectall in the keybind config files BY DEFAULT, i double checked on another machine.
This is most probably beacuse the CB relies on OS to handle them.
Now I tried to disable all plugins to test if that will fix it, but for some reason when i disable ThreadSearch plugin it causes a crash,
even more interesting when i searched for the crash report file "codeblocks.xml" i found it in folder "~$/.wine/dosdevices/z:/tmp"
Why would crash report end up in wine folder?
Everything here to me points to a problem how CB communicates with the OS or vice versa, but I'm not an expert.

[oBFusCATed]

This is most probably beacuse the CB relies on OS to handle them.

Highly unlikely. C::B relies on code in wx or scintilla to handle these...

Now I tried to disable all plugins to test if that will fix it, but for some reason when i disable ThreadSearch plugin it causes a crash

Known problem, unfortunately I've fixed it after 20.03 shipped.
Leave this plugin loaded or find its dll and delete it.

Everything here to me points to a problem how CB communicates with the OS or vice versa, but I'm not an expert.

I doubt it. The OS is too far away from this code to be related.

Are you saying that this problem happens with both 17.12 and 20.03? Do you have some strange non default software for clipboard or keyboard installed?

What kind of keyboard layout are you running? What is your locale?

[oBFusCATed]

Pretty similar sounding problem: https://sourceforge.net/p/codeblocks/tickets/950/

[gul]

Are you saying that this problem happens with both 17.12 and 20.03? Do you have some strange non default software for clipboard or keyboard installed?

What kind of keyboard layout are you running? What is your locale?

Yes i have this problem on both versions and no i don't use anything custom for keyboard or clipboard.

I'm from Serbia, but i use mostly ENG keyboard, i tried both just to be sure.
Interesting thing is that i actually changed the OS language from ENG to my native a few weeks ago (haven't used CB in 2 months)
but i tried to switch it back to ENG and that didn't solve the problem.
I also suspect that this might be related but i have no idea how to investigate further in this direction

Pretty similar sounding problem: https://sourceforge.net/p/codeblocks/tickets/950/

It doesn't feel to me like it is, because in my case all the shortcuts in the keybind config work(CTRL-Z, CTRL-S etc), only the ones that are handled separately don't.

I actually found out EXACTLY the same problem as mine posted already but there's no help in that topic:
http://forums.codeblocks.org/index.php/topic,22253.msg151491.html

[oBFusCATed]

I don't think this is related to your issue. In the past there was a problem, but it was fixed.

So are you able to reproduce the problem if the keybinder plugin is disabled/removed?
Is ctrl-u/ctrl-shift-u doing something if you have selected text in the editor?
What is the output of "locale -a" and "setxkbmap -query"?

[gul]

Yes, keybinder plugin wasn't even installed when i discovered this problem.
I selected some text but CTRL-U, and CTRL-SHIFT-U doesn't do anything.
I even dont know what are tease for, also couldn't find them in keybind config.

locale -a:

Code

C
C.UTF-8
en_AG
en_AG.utf8
en_AU.utf8
en_BW.utf8
en_CA.utf8
en_DK.utf8
en_GB.utf8
en_HK.utf8
en_IE.utf8
en_IL
en_IL.utf8
en_IN
en_IN.utf8
en_NG
en_NG.utf8
en_NZ.utf8
en_PH.utf8
en_SG.utf8
en_US.utf8
en_ZA.utf8
en_ZM
en_ZM.utf8
en_ZW.utf8
POSIX
sr_ME
sr_ME.utf8
sr_RS
sr_RS@latin
sr_RS.utf8
sr_RS.utf8@latin

setxkbmap -query:

Code

rules:      evdev
model:      pc105
layout:     rs,us,rs
variant:    ,,latin
options:    grp:shift_caps_toggle,grp:alt_shift_toggle

[oBFusCATed]

ctrl-u/shift-u make the selected text upper or lower case

Uf, I've requested the wrong command... it is just locale not locale -a

[oBFusCATed]

One more question:
Does pasting works in text controls?
For example: Can you paste something in Settings -> Environment -> General settings -> Shell to run commands in?

Also are you able to build the software manually. If you're able to paste this might be a clue to the problem...

[gul]

Hey thanks again for quick reply,

Yes in settings textboxes everything works properly, only in editor does not.

Also are you able to build the software manually.

I'm not sure what you mean, you want me to try to build CB from source on my machine or?

locale:

Code

LANG=sr_RS
LANGUAGE=sr_RS
LC_CTYPE="sr_RS"
LC_NUMERIC=sr_RS
LC_TIME=sr_RS
LC_COLLATE="sr_RS"
LC_MONETARY=sr_RS
LC_MESSAGES="sr_RS"
LC_PAPER=sr_RS
LC_NAME=sr_RS
LC_ADDRESS=sr_RS
LC_TELEPHONE=sr_RS
LC_MEASUREMENT=sr_RS
LC_IDENTIFICATION=sr_RS
LC_ALL=

[oBFusCATed]

Why are you using non-utf8 locale?

This is a commit which tried to make shortcuts work on non English locales/layout...
https://github.com/obfuscated/codeblocks_sf/commit/e26acf44b8ece212205423e2d57c392dc8ac2ad6
But I guess it doesn't work correctly.

Can you compile the latest wxwidgets master branch? You have to compile and test the samples/stc sample.
It would be interesting to know if shortcuts work there. My guess is that they won't work.

[oBFusCATed]

Also do you have scite, geany or something else which is based on scintilla? Does shortcuts work there?

[gul]

I didn't know non-UTF8 locale is a bad thing haha, why is that? I just recently changed it from default ENG.
Funny thing is i still have the problem even if i switch back to ENG locale.

I'll try to compile everything from source but it will take some time,

Ye I have geany it works as it should but its not codeblocks haha.

[oBFusCATed]

I guess the locale is not involved in this. But you definitely should use a utf8 locale, but it might be too late (if you have saved files with non-ascii symbols they might be broken if you change the locale). Using non-utf8 locale I think would mean that you either use a the upper half of the 1 byte or multi-byte/fixed size locale. You should read up. But generally programs on linux kind of expect a utf8...

[gul]

Ok, thanks, i changed the locale to UTF8, thankfully i didn't use non ANCII chars in beetween.

Anyway I compiled wxWidgets from git, and stc sample works correctly, i can copy paste etc. there.

After that i built CB from SVN and i still have the problem, but another thing is i ran CB from terminal and it keep printing this message:

Code

The Parser is still parsing files. > Reasons:
- still need to mark files as local

I get the same message on an overlay in editor while i type, dont know if its related.

 

[oBFusCATed]

I don't think the parsing problem is related.

On the original problem:
Interesting. So you don't have the problem in the stc sample...
Can you please put some printfs in the function I've highlighted in CB and do a build?

[gul]

Sorry, what function do you mean exactly?

[oBFusCATed]

This one https://github.com/obfuscated/codeblocks_sf/blob/e26acf44b8ece212205423e2d57c392dc8ac2ad6/src/sdk/wxscintilla/src/ScintillaWX.cpp#L1154

[gul]

Ok, i recomplited it with 4 printfs, it looks to me like the function registers keystrokes corrently, but still nothing happens on screen.

For example this is what i get with CTRL-A:

 

Code

1. KEY: 308  CTRL: 1 
2. KEY: 308  CTRL: 1 
4. KEY: 0  CTRL: 1  RV: 0 

1. KEY: 1729  CTRL: 1 
2. KEY: 1729  CTRL: 1 
4. KEY: 1729  CTRL: 1  RV: 0 

I used ENG keyboard.

[oBFusCATed]

What is the value of 'key' passed to KeyDownWithModifiers? For Ctrl-A it should be 'A' or 65...

Can you show me the result of git diff?

[gul]

I use mostly pure C and ASM, I'm not very good with Cpp so I don't fully understand what happens in int rv = KeyDownWithModifiers,
but to me it looks like when I press just CTRL i get 308, and A seems to be 1729,
I thought these are keycodes so they don't have to match actual ASCII char values, no?
And in that case shouldn't 65 / 'A' be CTRL-SHIFT-A ?

I used SVN instead of git because I had the files already, hope that's ok.

Code

Index: ScintillaWX.cpp
===================================================================
--- ScintillaWX.cpp	(revision 12064)
+++ ScintillaWX.cpp	(working copy)
@@ -1162,8 +1162,12 @@
     const int WXK_NONE = 0;
 #endif // wxCHECK_VERSION
 /* C::B end */
+
+    printf("1. KEY: %d  CTRL: %d \n",key,ctrl);
     if (ctrl && key >= 1 && key <= 26 && key != WXK_BACK)
         key += 'A' - 1;
+    
+    printf("2. KEY: %d  CTRL: %d \n",key,ctrl);
 
     switch (key) {
     case WXK_DOWN:              key = SCK_DOWN;     break;
@@ -1202,6 +1206,8 @@
     case WXK_SHIFT:             key = 0; break;
     case WXK_MENU:              key = SCK_MENU; break;
     case WXK_NONE:
+    
+    printf("3. KEY: %d  CTRL: %d \n",key,ctrl);
 #ifdef __WXGTK20__
         if (ctrl)
         {
@@ -1268,7 +1274,7 @@
                 ),
                 consumed
              );
-
+    printf("4. KEY: %d  CTRL: %d  RV: %d \n",key,ctrl,rv);
     if (key)
         return rv;
     else

[oBFusCATed]

This is the log from pressing ctrl-shift-a on my machine.

Code

1. KEY: 308  CTRL: 1
2. KEY: 308  CTRL: 1
4. KEY: 0  CTRL: 1  RV: 0
1. KEY: 306  CTRL: 1
2. KEY: 306  CTRL: 1
4. KEY: 0  CTRL: 1  RV: 0
1. KEY: 65  CTRL: 1
2. KEY: 65  CTRL: 1
4. KEY: 65  CTRL: 1  RV: 0

And this is ctrl-a

Code

1. KEY: 308  CTRL: 1
2. KEY: 308  CTRL: 1
4. KEY: 0  CTRL: 1  RV: 0
1. KEY: 65  CTRL: 1
2. KEY: 65  CTRL: 1
4. KEY: 65  CTRL: 1  RV: 0

This is the output of ctrl-a when I switch to bulgarian layout:

Code

1. KEY: 308  CTRL: 1
2. KEY: 308  CTRL: 1
4. KEY: 0  CTRL: 1  RV: 0
1. KEY: 0  CTRL: 1
2. KEY: 0  CTRL: 1
3. KEY: 0  CTRL: 1
4. KEY: 65  CTRL: 1  RV: 0

Can you apply the same patch to wx's stc and print the output?

[oBFusCATed]

I thought these are keycodes so they don't have to match actual ASCII char values, no?

See the code after "printf("3. KEY: %d  CTRL: %d \n",key,ctrl);"
Its job is to remap the keycode to the ASCII value.
The idea is to try to translate the pressed key to the key code if the same button is pressed on a qwerty English keyboard.

[gul]

Haha, ok i found out where the problem is. I have 3 keyboard layouts ENG, SER latin and SER cyrilic.
Now I was sure i tested all 3, but now when i tried again with the cyrilic layout it works !

This is the output.

Code

1. KEY: 308  CTRL: 1 
2. KEY: 308  CTRL: 1 
4. KEY: 0  CTRL: 1  RV: 0 
1. KEY: 0  CTRL: 1 
2. KEY: 0  CTRL: 1 
3. KEY: 0  CTRL: 1 
4. KEY: 65  CTRL: 1  RV: 0 

The problem is i use mostly ENG keyboard layout especially in CB. From what i see the code to convert the keycode to ASCII only runs in case WXK_NONE: (when the key is 0).
So on my machine it never enters that part of the code, beacuse i get 1729 for A on ENG layout.
I'll try to reset keyboard layout settings to see if that will fix the problem

[oBFusCATed]

But this code is exactly the same as the one used for the stc sample. Is it working there?

It could be quite helpful if you can get us the steps to setup a machine which breaks it. There is some problem and it is probably best to fix it when we're pretty close to it. I'm sure someone else would complain about it in the future.

[gul]

Ok i pinpointed the problem. When i installed my OS i setup only ENG layout as default. After install i added SER and SER latin keyboard layouts.

A few weeks ago i wanted to change the default layout to SER, so i moved it up in layout list
(it didn't actualy changed the default just the selection position, to change the default i need to rerun the whole config so i give up and left it like that).

But for some reason when SER is on top, only SER keyboard does work, when ENG is on top everything works correctly. I uploaded screenshot to see what i mean.
(First picture only SER works, second picture everything works)

Unfortunetly i deleted wxWidgest source files, but it was working there yes even when SER was on top, i can test it again if you want.

[gul]

Ok, i compiled wxWidgets again, its code is a little different it doesn't have ctrl variable,
 i added the same prinfts except ctrl var, and i got the same numbers,
A is 1792 on ENG layout when Serbian is on top of it in the settings, but everything works unlike in CB.

Code

1. KEY: 308  
2. KEY: 308  
4. KEY: 0  RV: 0 
1. KEY: 1729  
2. KEY: 1729  
4. KEY: 1729  RV: 0 

It doesn't make sense why would position in the layout list change anything other but the actual position?
So I think this is mostly bug in the OS, but because CB handles ctrl differently it shows up only in there.


p.s i just saw that we are actually neighbors, haha

Code

Христос Воскресе !

[oBFusCATed]

Ok, I can reproduce this in ubuntu 18.04 in vm...

edit: The fun thing is that adding serbian breaks English. I cannot type ls -l in a terminal any more. It comes out as ls 'l...

[gul]

Should I report this to debian/ubuntu/mint community or?

As the for the english break thing, i never experinced that, maybe you ware accidently using serbian latin

[oBFusCATed]

I'm not sure how many bugs I've hit there... Why do you have something like 6 or 7 layouts? In Bulgaria we have 3 and they are too many...

About the problem in C::B. I'm able to reproduce the problem in the stc sample, so there is no mystery there.
It is a lot harder, because ctrl-c/v/a are assigned to menu items and are handled by gtk, so they make the impression that shortcuts work, but this is not the case.
If you try ctrl-u/ctrl-shift-u you'll see that they don't work.
The way we do this is by reporting this to wx and waiting for a fix.

I'll try to find the original ticket and I'll post a message there...

[gul]

Haha I don't know why they made so many, people mostly use only 2 - cyrilic and latin.

I just found out layout at the top is actually the default layout, now finally everything makes sense to me haha

One more thing,
After i saw that you are from Bulgaria, I wondered who, how and when initially developed C::B,
but i couldn't find that information anywhere about history how C::B was born and the developers etc?

[Suryavarman]

May be the bug is the same :
https://sourceforge.net/p/codeblocks/tickets/950/