User forums > Using Code::Blocks

AUI text is unreadable in high contrast mode

(1/1)

mimi89999:
Hello,
AUI text is unreadable in high contrast mode. I fixed it in https://github.com/wxWidgets/wxWidgets/commit/697bd0744159e8c0ded7fb4174eecbfa41700e7c. Could you please consider applying this patch to wxWidgets when you will do the next release?

Miguel Gimenez:
I have been looking the patch for src/aui/barartmsw.cpp, and the text color for disabled buttons is still hardcoded in two methods (DrawButton and DrawDropDownButton). Also, for disabled buttons you set the color twice. I think


--- Code: ---dc.SetTextForeground(wxSystemSettings::GetColour(wxSYS_COLOUR_CAPTIONTEXT));
if ( item.GetState() & wxAUI_BUTTON_STATE_DISABLED )
    dc.SetTextForeground(DISABLED_TEXT_COLOR);

--- End code ---

should be


--- Code: ---if ( item.GetState() & wxAUI_BUTTON_STATE_DISABLED )
    dc.SetTextForeground(wxSystemSettings::GetColour(wxSYS_COLOUR_INACTIVECAPTIONTEXT));
else
    dc.SetTextForeground(wxSystemSettings::GetColour(wxSYS_COLOUR_CAPTIONTEXT));

--- End code ---

and this part can be removed


--- Code: ---static const unsigned char
DISABLED_TEXT_GREY_HUE = wxColour::AlphaBlend(0, 255, 0.4);
const wxColour DISABLED_TEXT_COLOR(DISABLED_TEXT_GREY_HUE,
    DISABLED_TEXT_GREY_HUE,
    DISABLED_TEXT_GREY_HUE);

--- End code ---

mimi89999:
Thanks. I will look at this.

mimi89999:
I would actually use `wxSYS_COLOUR_GRAYTEXT` instead of `wxSYS_COLOUR_INACTIVECAPTIONTEXT`.

oBFusCATed:

--- Quote from: mimi89999 on April 15, 2020, 12:20:07 pm ---Could you please consider applying this patch to wxWidgets when you will do the next release?

--- End quote ---
Only if they make an actual release. If not we'll pick only things which prevent crashes...

Navigation

[0] Message Index