Author Topic: The 15 December 2019 build (11927) is out.  (Read 35084 times)

Offline cacb

  • Lives here!
  • ****
  • Posts: 536
Re: The 15 December 2019 build (11927) is out.
« Reply #15 on: January 14, 2020, 09:51:21 am »
Please try to find which night build broke this.
It is either the switch to wx3.1.1 or wx3.1.3.

I encourage others to check this as well. I have little time to do this now, but I was able to check it in Nightly 11872 - it does not show the same problem.

Offline Miguel Gimenez

  • Developer
  • Lives here!
  • *****
  • Posts: 1551
Re: The 15 December 2019 build (11927) is out.
« Reply #16 on: January 14, 2020, 10:16:18 am »
11890 (wx3.1.1) works, 11918 (wx3.1.3) does not work (Windows 10)

EDIT: also fails in Windows 7
« Last Edit: January 14, 2020, 11:27:29 am by Miguel Gimenez »

Offline sodev

  • Regular
  • ***
  • Posts: 496
Re: The 15 December 2019 build (11927) is out.
« Reply #17 on: January 14, 2020, 06:23:27 pm »
I don't know how often sometimes is, i am also only on 11911 but there don't seem to be relevant changes up to 11918, but with wxWidgets@e093199 i cannot reproduce that.

Offline Xaviou

  • Regular
  • ***
  • Posts: 401
    • X@v's wxStuff
Re: The 15 December 2019 build (11927) is out.
« Reply #18 on: January 14, 2020, 06:41:01 pm »
Does this file exist?
Code
/Users/xavier/dev/CB/buildOSX/output/lib/codeblocks/plugins/libwxSmithAui.dylib

I wonder if it exists whether it might be a permission issue.

Just a wild guess from a Windows OS user.

Tim S.
Yes it does (and the 2 other libs that are in error too).
And the permissions are the same than the other files : -rwxr-xr-x

Regards
Xav'
The french wxWidgets site : http://www.wxdev.fr
My wxWidgets's stuff : https://wxstuff.xaviou.fr/

Offline cacb

  • Lives here!
  • ****
  • Posts: 536
Re: The 15 December 2019 build (11927) is out.
« Reply #19 on: January 14, 2020, 06:52:17 pm »
I don't know how often sometimes is, i am also only on 11911 but there don't seem to be relevant changes up to 11918, but with wxWidgets@e093199 i cannot reproduce that.
In my experience recently for this bug, "sometimes" means that it happens more often than not.  It is reproducible as explained erlier.

Offline Miguel Gimenez

  • Developer
  • Lives here!
  • *****
  • Posts: 1551
Re: The 15 December 2019 build (11927) is out.
« Reply #20 on: January 14, 2020, 07:15:21 pm »
I have tested r11954 (current head) with wx3.1.2 and there is no problem with IncrementalSearch, so the problem seems related to a change in wxWidgets made between 3.1.2 and 3.1.3

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13413
    • Travis build status
Re: The 15 December 2019 build (11927) is out.
« Reply #21 on: January 14, 2020, 07:48:33 pm »
@Miguel Gimenez: Would you have time to do a bisection of wx? Or try to debug why does it happen?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline grem

  • Multiple posting newcomer
  • *
  • Posts: 22
Re: The 15 December 2019 build (11927) is out.
« Reply #22 on: January 15, 2020, 08:39:15 am »
Quote
wx3.1.1 or wx3.1.3

@oBFusCATed, do you know is it planing to release Codeblocks 20.x afrer wxwidgets 3.2 release?

From https://trac.wxwidgets.org/wiki/Roadmap
Quote
we plan to release one last 3.1.4 release in 3.1.x series in the beginning of 2020 with 3.2.0 follwowing soon afterwards.

I ask because in the gentoo currently wxGTK-3.0-gtk3 is preferred for codeblocks-17.12 (live-ebuild is required update for it). And as I know there will not be wxGTK-3.1 in portage tree as it is development branch.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13413
    • Travis build status
Re: The 15 December 2019 build (11927) is out.
« Reply #23 on: January 15, 2020, 08:47:38 am »
There will be a release 20.xx, hopefully soon. We don't plan to wait wx to release whatever they release, because they are notorious for missing their release dates :). Using gtk3 at the moment is not a good idea if people aren't prepared to fix things, or at least report problems (in both wx and cb).
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline grem

  • Multiple posting newcomer
  • *
  • Posts: 22
Re: The 15 December 2019 build (11927) is out.
« Reply #24 on: January 15, 2020, 09:05:31 am »
Thank you for reply. Waiting with impatience :)

Unfortunately I currently use Codeblocks extremly rarely but during last two years there were not any issue reports about codeblocks + wxgtk-3.0-gtk3 (at least I don't remember about them as package maintainer). Therefore this revision in stable branch now.

So Codeblocks 20.xx in gentoo will be with wxGTK-3.0-gtk3 as gentoo wxwidgets team asked to use it for new revisions. Then after wxGTK-3.2-gtk3 release most likely there will be revision for it.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13413
    • Travis build status
Re: The 15 December 2019 build (11927) is out.
« Reply #25 on: January 15, 2020, 10:28:00 am »
I don't think it is a good idea to use gtk3, yet, even with trunk. From what I've seen there are problems. :(
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline Miguel Gimenez

  • Developer
  • Lives here!
  • *****
  • Posts: 1551
Re: The 15 December 2019 build (11927) is out.
« Reply #26 on: January 15, 2020, 01:48:13 pm »
This is the offending commit: Make wxComboCtrl a wxCompositeWindow

https://github.com/wxWidgets/wxWidgets/commit/70e9dbd756cb321fb85d6380b3e37bcd59604e09

This commit was reverted after wx3.1.3 release in commit https://github.com/wxWidgets/wxWidgets/commit/6b00cc80f1fdb3ef134e2df694a0c34905442042

Offline cacb

  • Lives here!
  • ****
  • Posts: 536
Re: The 15 December 2019 build (11927) is out.
« Reply #27 on: January 15, 2020, 06:41:26 pm »
@Miguel Gimenez : Well done! I hope to see a new nightly soon with this fixed.

Offline Miguel Gimenez

  • Developer
  • Lives here!
  • *****
  • Posts: 1551
Re: The 15 December 2019 build (11927) is out.
« Reply #28 on: January 16, 2020, 10:00:40 am »
Is there any good reason for using wxComboCtrl instead of wxComboBox?. The fancy customization capabilities of the former are not used (at first glance).

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 5906
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Re: The 15 December 2019 build (11927) is out.
« Reply #29 on: January 20, 2020, 02:54:11 am »
The font problem is because of a wxWidgets problem when loading fonts from string, introduced with version 2 of font serializing in wx3.1.2. It was reported by Ollydbg and it still unfixed.

https://trac.wxwidgets.org/ticket/18590

This issue is fixed in wx's trunk.

Allow parsing all fractional sizes in wxFont descriptions ยท wxWidgets/wxWidgets@a73194f

I think we should have this patch in C::B's wx 3.1.3 (in either nightly build or official 20.xx release)
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.