Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development

wxtrunk breaks compiling wxSmith; ctor of wxPGProperty has been made protected

<< < (4/5) > >>

sodev:

--- Quote from: oBFusCATed on July 09, 2019, 08:58:50 pm ---Does this fail in any build?

--- End quote ---

Does your commit from yesterday fail in any build?

The answer to both questions is the same :).

The removal of the #ifdefs is the same like in my patch and the same like the current code already did in other locations so this doesn't change anything. The only question is if setting the readonly property is possible in previous propgrid versions.

oBFusCATed:
@sodev: This is not helpful.

sodev:
Maybe i didn't understand your question correctly, i thought you wanted to know if this patch does do anything different than the last one you already applied in regard to features that may cause compatibility issues. I just confirmed that it does exactly the same like the last one plus that the other optimizations are safe.

If that wasn't your question, what was it then?

oBFusCATed:
No, this was not my question. The question is "which build fails without this patch".
I'm asking this because I can build the CodeBlocks_wx30-unix.workspace just fine without it.

Miguel Gimenez:
wxsChart uses wxParentProperty, jusrt like wxsStatusBar does. There where a build problem (identical to wxsStatusBar one) and both were fixed in commit 11783.

The issue fixed by this patch is making the wxParentProperty read only, like was done to wxsStatusBar in 11783.

Also I have unified some code using the macro NEW_IN_WXPG14X defined in wxsproperty.h just like wxsStatusBar does. No real change.

Navigation

[0] Message Index

[#] Next page

[*] Previous page