Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development
Keybinder v2 notes/problems
oBFusCATed:
You most probably have to change the eol property. I'll do it for you in a minute.
oBFusCATed:
--- Code: --- {
+ // FIXME (ph#):This call crashes KeyBinder, I'll fix soon.
+ if (lb->GetPageText(selection) == wxT("Keyboard shortcuts")) break;
--- End code ---
What is this? If you don't have this method implemented it should not crash! But you have to rebuild properly!!!
This doesn't probably work on translated C::Bs...
Pecan:
--- Quote from: oBFusCATed on April 09, 2020, 12:13:32 am ---
--- Code: --- {
+ // FIXME (ph#):This call crashes KeyBinder, I'll fix soon.
+ if (lb->GetPageText(selection) == wxT("Keyboard shortcuts")) break;
--- End code ---
What is this? If you don't have this method implemented it should not crash! But you have to rebuild properly!!!
This doesn't probably work on translated C::Bs...
--- End quote ---
What's a translated C::B ?
KeyBinder does not implement the call.
Are you actually able to configure your keys with KeyBinder after the addition of the OnPageChanging() call?
For me, Setting/Editor/KeyboardShortcuts crashes consistenly .
Even after a full rebuild of CB and it's plugins (on windows).
I've spent approximately 12 hours trying to find its' cause.
GDB only shows one frame with no meaningful information.
I'll eventually find the problem, but for now this is a temporary fix to allow users to set their key bindings.
oBFusCATed:
This happens because you have a duplicate configurationpanel.h file which doesn't have this method. I don't know why you do this but I doubt it is a good idea.
Next time when you have a problem with a change I've made, you can tell me. :)
Pecan:
--- Quote from: oBFusCATed on April 09, 2020, 10:20:52 am ---This happens because you have a duplicate configurationpanel.h file which doesn't have this method. I don't know why you do this but I doubt it is a good idea.
Next time when you have a problem with a change I've made, you can tell me. :)
--- End quote ---
I had no problem with your change. In fact I like it.
I only made that temporary fix to give me time to find the source of the crash. And I had all intentions of removing it.
Please don't feel offended.
Thanks for your work.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version