Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
(Another) enhancement for compiler interface GUI (+patch)
MortenMacFly:
--- Quote from: thomas on February 13, 2006, 03:01:13 pm ---Hmm, neither of these works... :lol:
--- End quote ---
No I'm confused. If I get mandrav right, then only the first lines need to be removed and then it's working, right?
...however, I'm trying the snd diff now... please wait a couple of minutes...
Morten.
thomas:
The problem is that this Index: line is expected for every patched file, so if your patch contains a dozen files, I have to modify all of them by hand. Plus, Tortoise is particularly picky about them, it even complains if the amount of spaces or equal signs is not the same, and it only lets you open a patch if all files in it are good... so it is a pain :lol:
On the other hand, when it does work, there is nothing better than TortoiseMerge to review patches . It's really great :)
MortenMacFly:
--- Quote from: thomas on February 13, 2006, 03:01:13 pm ---
--- Code: ---cd D:\EigeneDateien\Code\codeblocks\svn\src
svn diff > correct.patch
--- End code ---
--- End quote ---
I did and it seems to have worked. Please find the patch attached...
Morten.
Ps.: Knowing that this patch only changes a couple of lines we've spend quite some resources on that. But I'll do it better next time.
Pps.: mandrav: Do you mind adding ".patch" to the allowed extensions for this forum?
[attachment deleted by admin]
takeshimiya:
--- Quote from: MortenMacFly on February 13, 2006, 03:24:52 pm ---
--- Quote from: thomas on February 13, 2006, 03:01:13 pm ---
--- Code: ---cd D:\EigeneDateien\Code\codeblocks\svn\src
svn diff > correct.patch
--- End code ---
--- End quote ---
I did and it seems to have worked. Please find the patch attached...
Morten.
Ps.: Knowing that this patch only changes a couple of lines we've spend quite some resources on that. But I'll do it better next time.
Pps.: mandrav: Do you mind adding ".patch" to the allowed extensions for this forum?
--- End quote ---
I'll second to "any extension but .exe/.bat/.com/.cmd/.pif/.scr/.vbs".
thomas:
Applied the patch, although there are a few minor issues:
1. you can only clear the list if an item is selected (contra-intuitive)
2. the four buttons are a little too wide now, we may have to play with margins
3. you used a wxMessageBox which you shouldn't
ad 1.)
The button is explicitely disabled when no item is selected. I thought that it would be very smart to just remove that line, but this breaks the functionality for the whole dialog :?
ad 2.)
Reducing the border from 8 to 5 will probably do just fine, but I did not want to try that in a hurry now.
ad 3.)
This is not your fault, you could not possibly know that :lol:
A wxMessageBox will always appear on the primary display, as the application cannot place it correctly, so wxMessageBox should be avoided when possible. This is an undocumented rule so far.
Don't worry, there are still a few wxMessageBoxes around anyway, I'll fix them alltogether some day.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version