Author Topic: Patch for wxsglcanvas  (Read 10056 times)

Offline gd_on

  • Lives here!
  • ****
  • Posts: 796
Patch for wxsglcanvas
« on: March 06, 2020, 10:53:20 am »
I propose a patch in ticket 925 to add the possibility to activate multisample mode in wxSmith/wxsglcanvas. It is conditionnaly added/compiled if wxwidgets version is >= 3.0.0 because these possibilties (keywords) were not here before.
gd_on
Windows 11 64 bits (23H2), svn C::B (last version or almost!), wxWidgets 3.2.4 (tests with 3.3), Msys2 Compilers 13.2.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\msys64\mingw64) or 32 bits (dwarf2, posix  in C:\msys64\mingw32).

Offline stahta01

  • Lives here!
  • ****
  • Posts: 7582
    • My Best Post
Re: Patch for wxsglcanvas
« Reply #1 on: March 06, 2020, 10:58:50 am »
Please disable the tidy comment plugin and recreate patch without the comment changes it does.

Edit: Example changes not wanted
Code
-//------------------------------------------------------------------------------
+//----  --------------------------------------------------------------------------------------------------------

Tim S.
C Programmer working to learn more about C++ and Git.
On Windows 7 64 bit and Windows 10 64 bit.
--
When in doubt, read the CB WiKi FAQ. http://wiki.codeblocks.org

Offline gd_on

  • Lives here!
  • ****
  • Posts: 796
Re: Patch for wxsglcanvas
« Reply #2 on: March 06, 2020, 11:25:30 am »
OK. Patch modified. I hope that's what you wanted.
Windows 11 64 bits (23H2), svn C::B (last version or almost!), wxWidgets 3.2.4 (tests with 3.3), Msys2 Compilers 13.2.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\msys64\mingw64) or 32 bits (dwarf2, posix  in C:\msys64\mingw32).

Offline BlueHazzard

  • Developer
  • Lives here!
  • *****
  • Posts: 3353
Re: Patch for wxsglcanvas
« Reply #3 on: March 06, 2020, 12:20:24 pm »

Side note:
i am tired of all this #if version checking...
My proposal is to introduce a wxSmith setting, that stores the (minimal) wxWidgets version this project supports and then we check (for new code commits) in the code generation how the code has to be generated, according to this setting. Maybe we can even store this setting in the code itself?

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13413
    • Travis build status
Re: Patch for wxsglcanvas
« Reply #4 on: March 07, 2020, 12:36:55 am »
Patches welcome. Soon we will drop 2.8 support anyway...
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]