Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Thread Search crashes by design. RFC about proposed changes to events in SDK
Miguel Gimenez:
I don't think so, because DESTROY suggests that Window->Destroy() will be called, and in fact the purpose of this event is removing it from the log pane without destroying the window.
Detach is the verb used in wxWidgets for this action, see for example wxSizer::Detach()
https://docs.wxwidgets.org/trunk/classwx_sizer.html#a362d7d556185fe9cd1b5d24004b86518
ollydbg:
--- Quote from: Miguel Gimenez on January 25, 2019, 12:11:40 pm ---OK, the proposal then is:
- leave the original event untouched
- create a new event cbEVT_DETACH_LOG_WINDOW so ThreadSearch stops crashing
The modified patch is attached.
--- End quote ---
I'm testing your patch, and it works OK.
BTW, I see when I close C::B(without your patch), the C::B process is still seen in the Windows Task manager, so I have to manually select the C::B and kill it. But I can't find the reason under GDB, when I halt the GDB, I see backtrace contains some function call inside the wx library and waiting for the gui objects.
With your patch, I don't see this issue. (EDIT: the hang issue still happens with your patch, so this is not related)
--- Quote from: Miguel Gimenez on January 30, 2019, 04:41:23 pm ---I don't think so, because DESTROY suggests that Window->Destroy() will be called, and in fact the purpose of this event is removing it from the log pane without destroying the window.
Detach is the verb used in wxWidgets for this action, see for example wxSizer::Detach()
https://docs.wxwidgets.org/trunk/classwx_sizer.html#a362d7d556185fe9cd1b5d24004b86518
--- End quote ---
Thanks for the explanation, I think Detach is a good name.
oBFusCATed:
@ollydbg: I still think that we don't need this new event, so I prefer if you don't add it yet.
The problem is not that critical anyway, yes it is bad, but it is not blocking the usage of C::B for many people.
oBFusCATed:
This bug should be fix in master. Hopefully I've not broken something else. Testing is welcome.
Miguel Gimenez:
Ticket 807 https://sourceforge.net/p/codeblocks/tickets/807 has the same root causes and probably a similar solution.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version