User forums > Nightly builds

The 08 October 2018 build (11499) is out.

<< < (8/8)

Quiss:

--- Quote from: stahta01 on October 23, 2018, 12:14:40 am ---Can now duplicate the CPU high usage very fast with nightly build.
With FileManager Enabled, right click on folder and choose refresh under the Management pane and files tab

Tim S.

--- End quote ---
I've built several revisions and found that, this starts with rev11463; rev11462 is ok.

Windows 10-x64-v1809
wxWidgets3.1.1-x64 with mingw64-7.2.0

oBFusCATed:
Thanks for doing the bisect. It is obvious that this commit is wrong. I don't know where I've looked while doing the review.

Can you try if this change fixes it:

--- Code: ---diff --git a/src/plugins/contrib/FileManager/directorymonitor.cpp b/src/plugins/contrib/FileManager/directorymonitor.cpp
index e6dd9b64f..f95220d8d 100644
--- a/src/plugins/contrib/FileManager/directorymonitor.cpp
+++ b/src/plugins/contrib/FileManager/directorymonitor.cpp
@@ -370,10 +370,10 @@ public:
                 {
                     delete it->second;
                     it = m_monmap.erase(it);
+                    continue;
                 }
-                else
-                    ++it;
             }
+            ++it;
         }
         for(size_t i=0;i<update_paths.GetCount();i++)
         {

--- End code ---

Quiss:
Yes, this patch fixes the issue. No high cpu when right click-refresh folder, also it's been opened for half an hour.

Navigation

[0] Message Index

[*] Previous page