Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
User interface for project glob feature
BlueHazzard:
--- Quote from: Pecan on September 02, 2018, 08:23:37 pm ---
--- Quote from: BlueHazzard on September 02, 2018, 02:36:47 pm ---ok, i fixed it... I also removed the unnecessary delete from the list, and made the OK button default.
--- End quote ---
Cannot download file. Gets error "Failed- insufficient pemissions"
I tried 4 different ways to download. All failed.
--- End quote ---
hmm.. works for me...
anyway, i pushed it to github: https://github.com/bluehazzard/codeblocks_sf/tree/test/UnitsGlob/ui/3
oBFusCATed:
Works fine for me, too. :(
But a branch is a better idea. It will make reviewing it further easier if there are changes.
oBFusCATed:
The deletion is still not correct. .size() returns size_t, substituting 1 from 0 leads to very long loop and misery.
I don't think the sort is required, but if you still want to use it why don't you just reverse the list there?
p.s. vector has reverse iterators, which could save you the trouble to do correct iteration.
BlueHazzard:
The third time is the charm.
--- Quote ---The deletion is still not correct. .size() returns size_t, substituting 1 from 0 leads to very long loop and misery.
--- End quote ---
the good old unsigned underflow... Well it worked during testing...
--- Quote ---I don't think the sort is required, but if you still want to use it why don't you just reverse the list there?
--- End quote ---
I don't know how c++11 (lambdas) are welcome in the code, and i did not wanted to make a function or class only for sorting...
pushed the new code to github...
attached the 7ziped patch.. (no need to waste space...)
oBFusCATed:
Here are some fixes on top of yours: https://github.com/obfuscated/codeblocks_sf/tree/experiments/globs
Three more things I've found which needs to be fixed:
1. The manage dialog shouldn't call Manager::Get()->GetProjectManager()->GetActiveProject(), but a project pointer should be passed to the constructor. This would make it possible to add this manage command to the context menu
2. Adding a relative path to the current project makes the path look like ../myproj instead of just '.'.
3. The ok/cancel buttons in the manage dialog must be moved at the bottom using a stdbuttonsizer. The current version looks bad.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version