Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Threadsearch plugin cause crash when initilized (wx3.1,C::B svn head)
oBFusCATed:
--- Quote from: blauzahn on October 23, 2017, 09:20:44 pm ---To me, that looks like undefined behaviour:
--- End quote ---
I'll need a quote from the standard where they've made this undefined behaviour.
Newer compilers might delete the check, but this doesn't make the check undefined behaviour (if you find the quote from the standard, then I'll admit my mistake)!
--- Quote from: blauzahn on October 23, 2017, 09:20:44 pm ---A null-pointer check AFTER having dereferenced m_pViewManager.
If memory serves me, this in combination with "-fno-delete-null-pointer-checks"
led to bugs like heartbleed.
--- End quote ---
How is this related, to Code::Blocks where we don't care at all about security.
And it seems you're wrong, because by the looks of it (I have no time to read the whole report) heartbleed is just a logic error and nothing related to compilers or UB.
And finally how is this thing related to the original problem?
ollydbg:
--- Quote from: oBFusCATed on October 24, 2017, 12:37:46 am ---
And finally how is this thing related to the original problem?
--- End quote ---
I agree, it is not related.
ollydbg:
I see another strange issue, the combobox's content can't be saved after the dialog closed. When I close the option, and I see the combobox becomes "*.*" again. Any one can reproduce this issue? I'm on 32bit C::B build against wx3.1 under windows 7.
See image shot below:
danselmi:
--- Quote from: ollydbg on October 24, 2017, 01:59:17 am ---
--- Quote from: oBFusCATed on October 24, 2017, 12:37:46 am ---
And finally how is this thing related to the original problem?
--- End quote ---
I agree, it is not related.
--- End quote ---
It is not undefined behaviour. But the check is definitely too late. 4 lines above the m_pViewManager was already dereferenced.
oBFusCATed:
@ollydbg: Changing the value in the dialog works fine for me on linux with 3.1.1
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version