Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Scintilla 3.7.5 update
Jenna:
--- Quote from: ollydbg on August 19, 2017, 10:41:02 am ---Those timers are deleted in 4.0.0?
--- End quote ---
I did not look into the code, but we talk about 3.7.5 and not the coming 4.0.0, if I read it correctly. So they might still be needed.
oBFusCATed:
--- Quote from: ollydbg on August 19, 2017, 09:52:17 am ---I have to comment the line
--- Code: ---+//DEFINE_EVENT_TYPE( wxEVT_SCI_URIDROPPED );
--- End code ---
Because this is defined in the wx3.1, thus it cause conflict.
--- End quote ---
This doesn't make sense. The name of the event in wxwidgets is wxEVT_STC_URIDROPPED, so there is no way for it causes a conflict!
--- Quote from: ollydbg on August 19, 2017, 09:52:17 am ---I have also comment out the two function body
--- Code: ---void wxScintilla::UsePopUp(bool allowPopUp)
void wxScintilla::StartStyling(int start, int unused)
--- End code ---
Because they also cause build error.
--- End quote ---
What errors?
--- Quote from: ollydbg on August 19, 2017, 09:52:17 am ---But I see a lot of warnings like:
--- Code: ---sdk\wxscintilla\include/wx/wxscintilla.h:5613:51: warning: 'wxEVT_SCI_KEY' is deprecated: Don't handle wxEVT_SCI_KEY. It's never generated. [-Wdeprecated-declarations]
--- End code ---
--- End quote ---
Can you paste the lines of the build log which mention the uses of these deprecated declarations?
It seems the only place left is editor_hooks.cpp that mentions wxEVT_SCI_KEY.
--- Quote from: ollydbg on August 19, 2017, 10:41:02 am ---Question: at svn rev9896, some timers were added, I'm not sure those timers are still needed. I download a Scintilla 3.7.6 source code, and I see some platform like ScintillaWin, ScintillaGTK are still have those timers. (FineTickerAvailable() function get overwrite by those platforms, and return true)
--- End quote ---
The code in this branch is 99% the same as the code for wxstc in wxwidgets master branch.
They don't use fine timer granularity, so we're not using it also.
I want to keep our version of wxscintilla as close as the one in wxwidgets, so we could borrow code more easily.
As far as I know something changed in 3.6 that broke our implementation of the timers.
Morten knows more about this problem. So if he has time he could explain what should be done about these.
--- Quote from: ollydbg on August 19, 2017, 09:52:17 am ---But from the document here: Scintilla and SciTE
--- Quote --- Release 4.0.0 ....
--- End quote ---
--- End quote ---
We don't care for 4.x.x at the moment. It requires c++14 or 17 compiler and we can't use those because we need to support old linux distros.
For the next few years we'll be stuck to use only 3.x releases if there are more of them, which isn't very likely.
p.s. can someone provide patches for the other version of the codeblocks*.cbp files?
BlueHazzard:
i made all changes like ollydbg:
https://github.com/bluehazzard/codeblocks_sf/tree/scintilla_3_7_5
including:
--- Quote ---I have to comment the line
Code:
+//DEFINE_EVENT_TYPE( wxEVT_SCI_URIDROPPED );
Because this is defined in the wx3.1, thus it cause conflict.
--- End quote ---
ollydbg:
A discussion about the timers in wx is here: What is the reason that the STC(wxStyledTextCtrl) doesn't use FineTicker Timers? - Google Groups
New Pagodi:
Hi. I was pointed to this thread by the discussion linked above. I can explain some of the problems mentioned above.
For StartStyling, somewhere between the scintilla 3.6 releases and 3.7 releases, the signature to the the was changed from
--- Code: ---# Set the current styling position to pos and the styling mask to mask.
# The styling mask can be used to protect some bits in each styling byte from modification.
fun void StartStyling=2032(position pos, int mask)
--- End code ---
To
--- Code: ---# Set the current styling position to start.
# The unused parameter is no longer used and should be set to 0.
fun void StartStyling=2032(position start, int unused)
--- End code ---
Likewise, for the UsePopUp, the signature was changed from
--- Code: ---# Set whether a pop up menu is displayed automatically when the user presses
# the wrong mouse button.
fun void UsePopUp=2371(bool allowPopUp,)
--- End code ---
to
--- Code: ---# Set whether a pop up menu is displayed automatically when the user presses
# the wrong mouse button on certain areas.
fun void UsePopUp=2371(int popUpMode,)
--- End code ---
The change was made to allow popups to shown only if the mouse is clicked over the text portion of the window. The discussion on Trac about these things and a few other items that came up during the upgrade is available here.
The reason some of the events are causing deprecation warnings is due to the fact that they were defined for wxSTC, but none of the code ever generated them. It was decided to add those warnings to point out that handling those events won't ever do anything. The discussion about that issue can be seen here.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version