Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development

Proposed patch to ScriptedWizard with Extensions by YWX

<< < (2/3) > >>

oBFusCATed:

--- Quote from: Pecan on June 04, 2017, 07:03:05 pm ---Do you actually mean "I'll remove...." or do you mean you'd prefer me to remove.... ?

--- End quote ---
No, I hope I won't remove anything. I mean that I would prefer if you remove X or Y.

LETARTARE:
@pecan
in  'cbScriptedWizardPlugin->ArmNoneEabiWizard::GetJLinkDevices()'

--- Code: ---LinesDeviceCSV = GetArrayFromString(ContentDeviceCSV, _T("\r\n"), 0);
--- End code ---
is to verify because the file 'jlinkdevices.csv is saved with _T ( "\ n")
You either change 'jlinkdevices.csv' or the line of the program.

Pecan:
SVN reports that I don't have commit authority, so the patch is at:

https://sourceforge.net/p/codeblocks/tickets/519/

oBFusCATed:
You should probably send a PM to Morten, so he can give you access.

About the second patch:
1. Can you move the function comments before the method definition and change write them with a doxygen comment (no need to explain every parameter, just in case if we decide to generate doxygen docs for the full repo, not only for the sdk).
2. The initialization of m_WizardScriptFolder is strange. Could you redo it with the use of wxFileName?

Pecan:

--- Quote from: oBFusCATed on June 29, 2017, 09:49:45 pm ---You should probably send a PM to Morten, so he can give you access.

About the second patch:
1. Can you move the function comments before the method definition and change write them with a doxygen comment (no need to explain every parameter, just in case if we decide to generate doxygen docs for the full repo, not only for the sdk).
2. The initialization of m_WizardScriptFolder is strange. Could you redo it with the use of wxFileName?

--- End quote ---

Please go ahead and make the changes to your preferences and make the commit.

Navigation

[0] Message Index

[#] Next page

[*] Previous page