User forums > Help
Print error
LETARTARE:
I decided to repeat the tests systematically on the two panels displaying the same file.
These are the only versions I can still use (Vista Business Pack 2, TDM-GCC 4.7.1, wxWidgets unicode 2.8.12):
16.01, 10118, 10127, 10816, 10856, 10868, 10912, 10922 :
The upper pane prints the selected text.
The lower pane prints the entire file !!
I will try to search in the source, but I do not know where to look?
Do you know which functions handle printing?
Jenna:
--- Quote from: LETARTARE on January 16, 2017, 12:06:55 pm ---I decided to repeat the tests systematically on the two panels displaying the same file.
These are the only versions I can still use (Vista Business Pack 2, TDM-GCC 4.7.1, wxWidgets unicode 2.8.12):
16.01, 10118, 10127, 10816, 10856, 10868, 10912, 19022 :
The upper pane prints the selected text.
The lower pane prints the entire file !!
I will try to search in the source, but I do not know where to look?
Do you know which functions handle printing?
--- End quote ---
One issue is definitely, that the print-function always uses the first control, not the last active one.
Can you test the attached patch ?
LETARTARE:
Hello,
thanks for patch, good catch.
Of course, the value of pane 1 (m_pControl) was overwritten with the value of pane 2 in cbEditor::Print(bool selectionOnly, PrintColourMode pcm, bool line_numbers) !!
I only tested it on svn10922 : it's good.
Happy New Year.
Jenna:
--- Quote from: LETARTARE on January 16, 2017, 07:10:57 pm ---Hello,
thanks for patch, good catch.
Of course, the value of pane 1 (m_pControl) was overwritten with the value of pane 2 in cbEditor::Print(bool selectionOnly, PrintColourMode pcm, bool line_numbers) !!
I only tested it on svn19022 : it's good.
--- End quote ---
Do I understand it correctly, that the issues are gone with the patch ?
If yes and there are no objections from other devs, I can commit it.
--- Quote from: LETARTARE on January 16, 2017, 07:10:57 pm ---Happy New Year.
--- End quote ---
Many thanks, the same to you !
oBFusCATed:
--- Quote from: jens on January 16, 2017, 07:31:16 pm ---If yes and there are no objections from other devs, I can commit it.
--- End quote ---
Looks fine to me.
Jens are you able to print on linux?
My printing broke for some reason and there was another printing problem I'm no long able to look at. :(
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version